From: Al Viro <viro@ZenIV.linux.org.uk>
To: Eric Paris <eparis@redhat.com>
Cc: linux-kernel@vger.kernel.org, malware-list@lists.printk.net,
akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk,
arjan@infradead.org, hch@infradead.org, a.p.zijlstra@chello.nl
Subject: Re: [PATCH -v3 8/8] dnotify: reimplement dnotify using fsnotify
Date: Fri, 28 Nov 2008 05:14:43 +0000 [thread overview]
Message-ID: <20081128051443.GH28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20081125172133.17115.96807.stgit@paris.rdu.redhat.com>
On Tue, Nov 25, 2008 at 12:21:33PM -0500, Eric Paris wrote:
> + .mark_clear_inode = clear_mark_dir_notify,
... called under a spinlock
> +static void clear_mark_dir_notify(struct fsnotify_mark_entry *entry, struct inode *inode, unsigned long mask __attribute__ ((unused)), unsigned int flags)
> +{
...
> + fsnotify_put_group(dnotify_group);
... which grabs a mutex.
Incidentally, why the hell do you bother with refcounting on groups here?
dnotify is not something that's going to be unloaded, for fsck sake...
next prev parent reply other threads:[~2008-11-28 5:14 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 17:20 [PATCH -v3 0/8] file notification: fsnotify a unified file notification backend Eric Paris
2008-11-25 17:20 ` [PATCH -v3 1/8] filesystem notification: create fs/notify to contain all fs notification Eric Paris
2008-11-28 5:24 ` Al Viro
2008-11-25 17:21 ` [PATCH -v3 2/8] fsnotify: pass a file instead of an inode to open, read, and write Eric Paris
2008-11-25 17:21 ` [PATCH -v3 3/8] fsnotify: sys_execve and sys_uselib do not call into fsnotify Eric Paris
2008-11-28 10:16 ` Christoph Hellwig
2008-11-25 17:21 ` [PATCH -v3 4/8] fsnotify: use the new open-exec hook for inotify and dnotify Eric Paris
2008-11-25 17:21 ` [PATCH -v3 5/8] fsnotify: unified filesystem notification backend Eric Paris
2008-11-27 16:14 ` Peter Zijlstra
2008-11-27 16:17 ` Peter Zijlstra
2008-11-27 16:20 ` Peter Zijlstra
2008-11-28 23:22 ` Eric Paris
2008-11-28 23:39 ` Peter Zijlstra
2008-11-27 16:21 ` Peter Zijlstra
2008-11-28 4:54 ` Al Viro
2008-11-28 23:32 ` Eric Paris
2008-11-25 17:21 ` [PATCH -v3 6/8] fsnotify: add group priorities Eric Paris
2008-11-27 16:25 ` Peter Zijlstra
2008-12-01 15:20 ` Eric Paris
2008-12-01 15:37 ` Peter Zijlstra
2008-11-25 17:21 ` [PATCH -v3 7/8] fsnotify: add in inode fsnotify markings Eric Paris
2008-11-27 16:29 ` Peter Zijlstra
2008-11-28 5:42 ` Al Viro
2008-11-28 23:43 ` Eric Paris
2008-11-25 17:21 ` [PATCH -v3 8/8] dnotify: reimplement dnotify using fsnotify Eric Paris
2008-11-28 5:14 ` Al Viro [this message]
2008-11-28 23:37 ` Eric Paris
2008-11-28 6:25 ` Al Viro
2008-11-28 23:44 ` Eric Paris
2008-11-26 0:14 ` [PATCH -v3 0/8] file notification: fsnotify a unified file notification backend Andrew Morton
2008-11-26 2:00 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081128051443.GH28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=eparis@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=malware-list@lists.printk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox