public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Walmsley <paul@pwsan.com>
To: linux-arm-kernel@lists.arm.linux.org.uk, linux-kernel@vger.kernel.org
Cc: linux-omap@vger.kernel.org, Paul Walmsley <paul@pwsan.com>,
	Tony Lindgren <tony@atomide.com>
Subject: [PATCH F 06/12] OMAP2/3 clock: every clock must have a clkdm
Date: Wed, 28 Jan 2009 12:35:15 -0700	[thread overview]
Message-ID: <20090128193512.2396.75340.stgit@localhost.localdomain> (raw)
In-Reply-To: <20090128193326.2396.9437.stgit@localhost.localdomain>

Every OMAP2/3 clock must now have an assigned clockdomain, so we can
remove the checks from clk_enable()/clk_disable().  Instead, verify
that the clockdomain is present only at clock init time via the
arch_clock clk_register() hook.

linux-omap source commit is 60b8b431e47d8c5b8c02a2e4fa9af388aae20790.

Signed-off-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/mach-omap2/clock.c |   20 +++++++++-----------
 1 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c
index c93a5aa..600b2f4 100644
--- a/arch/arm/mach-omap2/clock.c
+++ b/arch/arm/mach-omap2/clock.c
@@ -199,11 +199,6 @@ void omap2_init_clk_clkdm(struct clk *clk)
 {
 	struct clockdomain *clkdm;
 
-	if (!clk->clkdm.name) {
-		pr_err("clock: %s: missing clockdomain", clk->name);
-		return;
-	}
-
 	clkdm = clkdm_lookup(clk->clkdm.name);
 	if (clkdm) {
 		pr_debug("clock: associated clk %s to clkdm %s\n",
@@ -479,8 +474,7 @@ void omap2_clk_disable(struct clk *clk)
 		_omap2_clk_disable(clk);
 		if (clk->parent)
 			omap2_clk_disable(clk->parent);
-		if (clk->clkdm.ptr)
-			omap2_clkdm_clk_disable(clk->clkdm.ptr, clk);
+		omap2_clkdm_clk_disable(clk->clkdm.ptr, clk);
 
 	}
 }
@@ -498,14 +492,12 @@ int omap2_clk_enable(struct clk *clk)
 			return ret;
 		}
 
-		if (clk->clkdm.ptr)
-			omap2_clkdm_clk_enable(clk->clkdm.ptr, clk);
+		omap2_clkdm_clk_enable(clk->clkdm.ptr, clk);
 
 		ret = _omap2_clk_enable(clk);
 
 		if (ret != 0) {
-			if (clk->clkdm.ptr)
-				omap2_clkdm_clk_disable(clk->clkdm.ptr, clk);
+			omap2_clkdm_clk_disable(clk->clkdm.ptr, clk);
 
 			if (clk->parent) {
 				omap2_clk_disable(clk->parent);
@@ -1090,6 +1082,12 @@ void omap2_clk_disable_unused(struct clk *clk)
 
 int omap2_clk_register(struct clk *clk)
 {
+	if (!clk->clkdm.name) {
+		pr_debug("clock: %s: missing clockdomain", clk->name);
+		WARN_ON(1);
+		return -EINVAL;
+	}
+
 	omap2_init_clk_clkdm(clk);
 	return 0;
 }



  parent reply	other threads:[~2009-01-28 20:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-28 19:34 [PATCH F 00/12] OMAP clock, F of F: more clock cleanup Paul Walmsley
2009-01-28 19:35 ` [PATCH F 01/12] OMAP2/3 clock: don't use a barrier after clk_disable() Paul Walmsley
2009-01-28 19:35 ` [PATCH F 02/12] OMAP2xxx clock: consolidate DELAYED_APP clock commits; fix barrier Paul Walmsley
2009-01-28 19:35 ` [PATCH F 03/12] OMAP2/3 clock: convert remaining MPU barriers into OCP barriers Paul Walmsley
2009-01-28 19:35 ` [PATCH F 04/12] OMAP clock: drop clk_get_usecount() Paul Walmsley
2009-01-28 19:35 ` [PATCH F 05/12] OMAP clock: add OMAP chip family-specific clk_register() option Paul Walmsley
2009-01-28 19:35 ` Paul Walmsley [this message]
2009-01-31 14:08   ` [PATCH F 06/12] OMAP2/3 clock: every clock must have a clkdm Russell King - ARM Linux
2009-02-03  9:27     ` Paul Walmsley
2009-02-03 14:20       ` Woodruff, Richard
2009-02-05  9:03         ` Paul Walmsley
2009-01-28 19:35 ` [PATCH F 07/12] OMAP2/3 clock: omap2_clk_enable(): refactor usecount check Paul Walmsley
2009-01-28 19:35 ` [PATCH F 08/12] OMAP2/3 clock: omap2_clk_enable(): fix bugs in clockdomain handling Paul Walmsley
2009-01-28 19:35 ` [PATCH F 09/12] OMAP2/3 clock: omap2_clk_enable(): fix usecount decrement bug Paul Walmsley
2009-01-28 19:35 ` [PATCH F 10/12] OMAP2/3 clock: omap2_clk_enable(): fix logic Paul Walmsley
2009-01-31 10:58   ` Russell King - ARM Linux
2009-02-02  8:01     ` Paul Walmsley
2009-01-28 19:35 ` [PATCH F 11/12] OMAP2/3 clock: don't tinker with hardirqs when they are supposed to be disabled Paul Walmsley
2009-01-28 19:35 ` [PATCH F 12/12] OMAP2/3 McBSP: add temporary clockdomain fix for McBSP virtual clocks Paul Walmsley
2009-01-31 11:42   ` Russell King - ARM Linux
2009-02-02  8:09     ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090128193512.2396.75340.stgit@localhost.localdomain \
    --to=paul@pwsan.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox