From: Paul Walmsley <paul@pwsan.com>
To: linux-arm-kernel@lists.arm.linux.org.uk, linux-kernel@vger.kernel.org
Cc: linux-omap@vger.kernel.org, Paul Walmsley <paul@pwsan.com>,
Tony Lindgren <tony@atomide.com>
Subject: [PATCH F 07/12] OMAP2/3 clock: omap2_clk_enable(): refactor usecount check
Date: Wed, 28 Jan 2009 12:35:19 -0700 [thread overview]
Message-ID: <20090128193515.2396.44218.stgit@localhost.localdomain> (raw)
In-Reply-To: <20090128193326.2396.9437.stgit@localhost.localdomain>
Clean up omap2_clk_enable() by moving most of the function body out of
the usecount check. Should result in no functional change.
linux-omap source commit is 18d4ecba1c1afc52379d5395766f442948822fc0.
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/mach-omap2/clock.c | 31 ++++++++++++++++---------------
1 files changed, 16 insertions(+), 15 deletions(-)
diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c
index 600b2f4..6ab9de3 100644
--- a/arch/arm/mach-omap2/clock.c
+++ b/arch/arm/mach-omap2/clock.c
@@ -483,26 +483,27 @@ int omap2_clk_enable(struct clk *clk)
{
int ret = 0;
- if (clk->usecount++ == 0) {
- if (clk->parent)
- ret = omap2_clk_enable(clk->parent);
+ if (++clk->usecount > 1)
+ return 0;
- if (ret != 0) {
- clk->usecount--;
- return ret;
- }
+ if (clk->parent)
+ ret = omap2_clk_enable(clk->parent);
+
+ if (ret != 0) {
+ clk->usecount--;
+ return ret;
+ }
- omap2_clkdm_clk_enable(clk->clkdm.ptr, clk);
+ omap2_clkdm_clk_enable(clk->clkdm.ptr, clk);
- ret = _omap2_clk_enable(clk);
+ ret = _omap2_clk_enable(clk);
- if (ret != 0) {
- omap2_clkdm_clk_disable(clk->clkdm.ptr, clk);
+ if (ret != 0) {
+ omap2_clkdm_clk_disable(clk->clkdm.ptr, clk);
- if (clk->parent) {
- omap2_clk_disable(clk->parent);
- clk->usecount--;
- }
+ if (clk->parent) {
+ omap2_clk_disable(clk->parent);
+ clk->usecount--;
}
}
next prev parent reply other threads:[~2009-01-28 20:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 19:34 [PATCH F 00/12] OMAP clock, F of F: more clock cleanup Paul Walmsley
2009-01-28 19:35 ` [PATCH F 01/12] OMAP2/3 clock: don't use a barrier after clk_disable() Paul Walmsley
2009-01-28 19:35 ` [PATCH F 02/12] OMAP2xxx clock: consolidate DELAYED_APP clock commits; fix barrier Paul Walmsley
2009-01-28 19:35 ` [PATCH F 03/12] OMAP2/3 clock: convert remaining MPU barriers into OCP barriers Paul Walmsley
2009-01-28 19:35 ` [PATCH F 04/12] OMAP clock: drop clk_get_usecount() Paul Walmsley
2009-01-28 19:35 ` [PATCH F 05/12] OMAP clock: add OMAP chip family-specific clk_register() option Paul Walmsley
2009-01-28 19:35 ` [PATCH F 06/12] OMAP2/3 clock: every clock must have a clkdm Paul Walmsley
2009-01-31 14:08 ` Russell King - ARM Linux
2009-02-03 9:27 ` Paul Walmsley
2009-02-03 14:20 ` Woodruff, Richard
2009-02-05 9:03 ` Paul Walmsley
2009-01-28 19:35 ` Paul Walmsley [this message]
2009-01-28 19:35 ` [PATCH F 08/12] OMAP2/3 clock: omap2_clk_enable(): fix bugs in clockdomain handling Paul Walmsley
2009-01-28 19:35 ` [PATCH F 09/12] OMAP2/3 clock: omap2_clk_enable(): fix usecount decrement bug Paul Walmsley
2009-01-28 19:35 ` [PATCH F 10/12] OMAP2/3 clock: omap2_clk_enable(): fix logic Paul Walmsley
2009-01-31 10:58 ` Russell King - ARM Linux
2009-02-02 8:01 ` Paul Walmsley
2009-01-28 19:35 ` [PATCH F 11/12] OMAP2/3 clock: don't tinker with hardirqs when they are supposed to be disabled Paul Walmsley
2009-01-28 19:35 ` [PATCH F 12/12] OMAP2/3 McBSP: add temporary clockdomain fix for McBSP virtual clocks Paul Walmsley
2009-01-31 11:42 ` Russell King - ARM Linux
2009-02-02 8:09 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090128193515.2396.44218.stgit@localhost.localdomain \
--to=paul@pwsan.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox