From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-arm-kernel@lists.arm.linux.org.uk,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH F 06/12] OMAP2/3 clock: every clock must have a clkdm
Date: Sat, 31 Jan 2009 14:08:04 +0000 [thread overview]
Message-ID: <20090131140804.GH1394@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20090128193512.2396.75340.stgit@localhost.localdomain>
On Wed, Jan 28, 2009 at 12:35:15PM -0700, Paul Walmsley wrote:
> Every OMAP2/3 clock must now have an assigned clockdomain, so we can
> remove the checks from clk_enable()/clk_disable(). Instead, verify
> that the clockdomain is present only at clock init time via the
> arch_clock clk_register() hook.
I don't see the point of requiring all clocks to have a clockdomain field.
Given that we have virtual clocks, it is quite reasonable for some clocks
not to have a clock domain associated with them.
The overhead for avoiding this requirement isn't that great, and I feel
that there's little benefit from this change.
next prev parent reply other threads:[~2009-01-31 14:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 19:34 [PATCH F 00/12] OMAP clock, F of F: more clock cleanup Paul Walmsley
2009-01-28 19:35 ` [PATCH F 01/12] OMAP2/3 clock: don't use a barrier after clk_disable() Paul Walmsley
2009-01-28 19:35 ` [PATCH F 02/12] OMAP2xxx clock: consolidate DELAYED_APP clock commits; fix barrier Paul Walmsley
2009-01-28 19:35 ` [PATCH F 03/12] OMAP2/3 clock: convert remaining MPU barriers into OCP barriers Paul Walmsley
2009-01-28 19:35 ` [PATCH F 04/12] OMAP clock: drop clk_get_usecount() Paul Walmsley
2009-01-28 19:35 ` [PATCH F 05/12] OMAP clock: add OMAP chip family-specific clk_register() option Paul Walmsley
2009-01-28 19:35 ` [PATCH F 06/12] OMAP2/3 clock: every clock must have a clkdm Paul Walmsley
2009-01-31 14:08 ` Russell King - ARM Linux [this message]
2009-02-03 9:27 ` Paul Walmsley
2009-02-03 14:20 ` Woodruff, Richard
2009-02-05 9:03 ` Paul Walmsley
2009-01-28 19:35 ` [PATCH F 07/12] OMAP2/3 clock: omap2_clk_enable(): refactor usecount check Paul Walmsley
2009-01-28 19:35 ` [PATCH F 08/12] OMAP2/3 clock: omap2_clk_enable(): fix bugs in clockdomain handling Paul Walmsley
2009-01-28 19:35 ` [PATCH F 09/12] OMAP2/3 clock: omap2_clk_enable(): fix usecount decrement bug Paul Walmsley
2009-01-28 19:35 ` [PATCH F 10/12] OMAP2/3 clock: omap2_clk_enable(): fix logic Paul Walmsley
2009-01-31 10:58 ` Russell King - ARM Linux
2009-02-02 8:01 ` Paul Walmsley
2009-01-28 19:35 ` [PATCH F 11/12] OMAP2/3 clock: don't tinker with hardirqs when they are supposed to be disabled Paul Walmsley
2009-01-28 19:35 ` [PATCH F 12/12] OMAP2/3 McBSP: add temporary clockdomain fix for McBSP virtual clocks Paul Walmsley
2009-01-31 11:42 ` Russell King - ARM Linux
2009-02-02 8:09 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090131140804.GH1394@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox