From: Felipe Balbi <me@felipebalbi.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: me@felipebalbi.com, Bryan Wu <cooloney@kernel.org>,
felipe.balbi@nokia.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: musb: tweak musb_read_fifo() to avoid unused warnings
Date: Fri, 6 Feb 2009 21:30:27 +0200 [thread overview]
Message-ID: <20090206193027.GF10711@frodo> (raw)
In-Reply-To: <8bd0f97a0902061128r70cecec3p4c927f2daa38d517@mail.gmail.com>
On Fri, Feb 06, 2009 at 02:28:46PM -0500, Mike Frysinger wrote:
> >> the subject already says that
> >
> > the subject says:
> >
> > "tweak musb_read_fifo() to avoid unused warnings"
> >
> > it doesn't specify where are the warnings.
>
> i dont think it really adds anything to explicitly mention every
> variable that triggers an unused warning. but if we look at the code
> that changed, it's easy to see that it's epnum and dma_reg.
Still I like to see patch bodies otherwise git log will look awkward.
--
balbi
next prev parent reply other threads:[~2009-02-06 19:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 10:22 [PATCH] usb: musb: tweak musb_read_fifo() to avoid unused warnings Bryan Wu
2009-02-06 19:15 ` Felipe Balbi
2009-02-06 19:24 ` Mike Frysinger
2009-02-06 19:26 ` Felipe Balbi
2009-02-06 19:28 ` Mike Frysinger
2009-02-06 19:30 ` Felipe Balbi [this message]
2009-02-12 6:01 ` David Brownell
2009-02-07 0:01 ` Greg KH
2009-02-07 4:29 ` Mike Frysinger
2009-02-07 5:34 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090206193027.GF10711@frodo \
--to=me@felipebalbi.com \
--cc=cooloney@kernel.org \
--cc=felipe.balbi@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox