From: David Brownell <david-b@pacbell.net>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: me@felipebalbi.com, Bryan Wu <cooloney@kernel.org>,
felipe.balbi@nokia.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: musb: tweak musb_read_fifo() to avoid unused warnings
Date: Wed, 11 Feb 2009 22:01:12 -0800 [thread overview]
Message-ID: <200902112201.12902.david-b@pacbell.net> (raw)
In-Reply-To: <8bd0f97a0902061124s3c44d39dmf306a44f0c16528d@mail.gmail.com>
On Friday 06 February 2009, Mike Frysinger wrote:
> > Is this patch avoiding a warning about these variables being unused ?
> >
> > Would be nice to get this info to the patch body ;-)
>
> the subject already says that
Not enough.
Mike, why is it that patches from ADI generally don't include
patch descriptions? It's not like folk haven't asked for them...
In the case of "avoid a warning" patches, the convention is to
have the patch summary include the warnings being avoided.
(Or at least a few, if they're too numerous.)
next prev parent reply other threads:[~2009-02-12 6:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 10:22 [PATCH] usb: musb: tweak musb_read_fifo() to avoid unused warnings Bryan Wu
2009-02-06 19:15 ` Felipe Balbi
2009-02-06 19:24 ` Mike Frysinger
2009-02-06 19:26 ` Felipe Balbi
2009-02-06 19:28 ` Mike Frysinger
2009-02-06 19:30 ` Felipe Balbi
2009-02-12 6:01 ` David Brownell [this message]
2009-02-07 0:01 ` Greg KH
2009-02-07 4:29 ` Mike Frysinger
2009-02-07 5:34 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902112201.12902.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=cooloney@kernel.org \
--cc=felipe.balbi@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=me@felipebalbi.com \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox