Re: [PATCH] usb: musb: tweak musb_read_fifo() to avoid unused warnings

[Greg KH <greg@kroah.com>]

On Fri, Feb 06, 2009 at 11:29:54PM -0500, Mike Frysinger wrote:
> On Fri, Feb 6, 2009 at 19:01, Greg KH wrote:
> > On Fri, Feb 06, 2009 at 06:22:16PM +0800, Bryan Wu wrote:
> >> From: Mike Frysinger <vapier.adi@gmail.com>
> >>
> >> Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
> >> Signed-off-by: Bryan Wu <cooloney@kernel.org>
> >> ---
> >>  drivers/usb/musb/blackfin.c |    9 +++++----
> >>  1 files changed, 5 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb/musb/blackfin.c
> >> index 7861348..0ebb19d 100644
> >> --- a/drivers/usb/musb/blackfin.c
> >> +++ b/drivers/usb/musb/blackfin.c
> >> @@ -54,13 +54,11 @@ void musb_write_fifo(struct musb_hw_ep *hw_ep, u16 len, const u8 *src)
> >>  void musb_read_fifo(struct musb_hw_ep *hw_ep, u16 len, u8 *dst)
> >>  {
> >>       void __iomem *fifo = hw_ep->fifo;
> >> +
> >> +#ifdef CONFIG_BF52x
> >
> > Any way we can just not have ifdefs in .c files alltogether?
> 
> the sub arch.c files for musb are pretty much header files.  the
> alternative (splitting up the funcs into their own header files) would
> be much more bothersome for us to maintain atm i think since there's
> so very little different.

Ick.  Oh well, any cleanup that people can think of would be good in
this area...

thanks,

greg k-h