* [PATCH] PCIe portdrv: eliminate double kfree in remove path
@ 2009-03-09 18:08 Alex Chiang
2009-03-09 21:19 ` Rafael J. Wysocki
2009-03-20 1:43 ` Jesse Barnes
0 siblings, 2 replies; 3+ messages in thread
From: Alex Chiang @ 2009-03-09 18:08 UTC (permalink / raw)
To: Jesse Barnes, rjw; +Cc: linux-pci, linux-kernel
Commit 55633af3 (PCIe portdrv: Use driver data to simplify code)
added a kfree of the driver private data in pcie_port_device_remove
but forgot to remove the old kfree from pcie_portdrv_remove.
Signed-off-by: Alex Chiang <achiang@hp.com>
---
diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
index a6fee6c..f2368b1 100644
--- a/drivers/pci/pcie/portdrv_pci.c
+++ b/drivers/pci/pcie/portdrv_pci.c
@@ -93,7 +93,6 @@ static int __devinit pcie_portdrv_probe (struct pci_dev *dev,
static void pcie_portdrv_remove (struct pci_dev *dev)
{
pcie_port_device_remove(dev);
- kfree(pci_get_drvdata(dev));
}
static int error_detected_iter(struct device *device, void *data)
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] PCIe portdrv: eliminate double kfree in remove path
2009-03-09 18:08 [PATCH] PCIe portdrv: eliminate double kfree in remove path Alex Chiang
@ 2009-03-09 21:19 ` Rafael J. Wysocki
2009-03-20 1:43 ` Jesse Barnes
1 sibling, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2009-03-09 21:19 UTC (permalink / raw)
To: Alex Chiang; +Cc: Jesse Barnes, linux-pci, linux-kernel
On Monday 09 March 2009, Alex Chiang wrote:
> Commit 55633af3 (PCIe portdrv: Use driver data to simplify code)
> added a kfree of the driver private data in pcie_port_device_remove
> but forgot to remove the old kfree from pcie_portdrv_remove.
Ah, sorry for that, it resulted in quite a lot of debugging work for you. :-(
> Signed-off-by: Alex Chiang <achiang@hp.com>
Acked-by; Rafael J. Wysocki <rjw@sisk.pl>
> ---
> diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
> index a6fee6c..f2368b1 100644
> --- a/drivers/pci/pcie/portdrv_pci.c
> +++ b/drivers/pci/pcie/portdrv_pci.c
> @@ -93,7 +93,6 @@ static int __devinit pcie_portdrv_probe (struct pci_dev *dev,
> static void pcie_portdrv_remove (struct pci_dev *dev)
> {
> pcie_port_device_remove(dev);
> - kfree(pci_get_drvdata(dev));
> }
>
> static int error_detected_iter(struct device *device, void *data)
> --
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] PCIe portdrv: eliminate double kfree in remove path
2009-03-09 18:08 [PATCH] PCIe portdrv: eliminate double kfree in remove path Alex Chiang
2009-03-09 21:19 ` Rafael J. Wysocki
@ 2009-03-20 1:43 ` Jesse Barnes
1 sibling, 0 replies; 3+ messages in thread
From: Jesse Barnes @ 2009-03-20 1:43 UTC (permalink / raw)
To: Alex Chiang; +Cc: rjw, linux-pci, linux-kernel
On Mon, 9 Mar 2009 12:08:15 -0600
Alex Chiang <achiang@hp.com> wrote:
> Commit 55633af3 (PCIe portdrv: Use driver data to simplify code)
> added a kfree of the driver private data in pcie_port_device_remove
> but forgot to remove the old kfree from pcie_portdrv_remove.
>
> Signed-off-by: Alex Chiang <achiang@hp.com>
Applied, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-03-20 1:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-09 18:08 [PATCH] PCIe portdrv: eliminate double kfree in remove path Alex Chiang
2009-03-09 21:19 ` Rafael J. Wysocki
2009-03-20 1:43 ` Jesse Barnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox