[PATCH] virtio: add missing include to virtio_net.h

[PATCH] virtio: add missing include to virtio_net.h

[Grant Likely]

From: Grant Likely <grant.likely@secretlab.ca>

virtio_net.h uses the macro ETH_ALEN which is defined in linux/if_ether.h.
Discovered when hacking on virtio-over-pci patches.

Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---

 include/linux/virtio_net.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h
index 242348b..cec79ad 100644
--- a/include/linux/virtio_net.h
+++ b/include/linux/virtio_net.h
@@ -4,6 +4,7 @@
  * compatible drivers/servers. */
 #include <linux/types.h>
 #include <linux/virtio_config.h>
+#include <linux/if_ether.h>
 
 /* The ID for virtio_net */
 #define VIRTIO_ID_NET	1

Re: [PATCH] virtio: add missing include to virtio_net.h

[David Miller]

From: Grant Likely <grant.likely@secretlab.ca>
Date: Tue, 28 Apr 2009 09:46:54 -0600

[ Grant, please CC: netdev on networking patches, thanks. ]

> virtio_net.h uses the macro ETH_ALEN which is defined in linux/if_ether.h.
> Discovered when hacking on virtio-over-pci patches.
> 
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>

Rusty, ACK?

I haven't been able to get responses from Rusty on virtio net
patches, so if he doesn't start responding soon I'm going to
integrates the fixes I've seen lately as they all look
reasonable to me.

> ---
> 
>  include/linux/virtio_net.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> 
> diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h
> index 242348b..cec79ad 100644
> --- a/include/linux/virtio_net.h
> +++ b/include/linux/virtio_net.h
> @@ -4,6 +4,7 @@
>   * compatible drivers/servers. */
>  #include <linux/types.h>
>  #include <linux/virtio_config.h>
> +#include <linux/if_ether.h>
>  
>  /* The ID for virtio_net */
>  #define VIRTIO_ID_NET	1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] virtio: add missing include to virtio_net.h

[Grant Likely]

On Wed, Apr 29, 2009 at 6:49 PM, David Miller <davem@davemloft.net> wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
> Date: Tue, 28 Apr 2009 09:46:54 -0600
>
> [ Grant, please CC: netdev on networking patches, thanks. ]

Oops, sorry about that; I had in my head "virtio" and it didn't even
occur to me that it was also netdev.  :-)

g.

>
>> virtio_net.h uses the macro ETH_ALEN which is defined in linux/if_ether.h.
>> Discovered when hacking on virtio-over-pci patches.
>>
>> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
>
> Rusty, ACK?
>
> I haven't been able to get responses from Rusty on virtio net
> patches, so if he doesn't start responding soon I'm going to
> integrates the fixes I've seen lately as they all look
> reasonable to me.
>
>> ---
>>
>>  include/linux/virtio_net.h |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>>
>> diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h
>> index 242348b..cec79ad 100644
>> --- a/include/linux/virtio_net.h
>> +++ b/include/linux/virtio_net.h
>> @@ -4,6 +4,7 @@
>>   * compatible drivers/servers. */
>>  #include <linux/types.h>
>>  #include <linux/virtio_config.h>
>> +#include <linux/if_ether.h>
>>
>>  /* The ID for virtio_net */
>>  #define VIRTIO_ID_NET        1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

Re: [PATCH] virtio: add missing include to virtio_net.h

[David Miller]

From: Grant Likely <grant.likely@secretlab.ca>
Date: Tue, 28 Apr 2009 09:46:54 -0600

> virtio_net.h uses the macro ETH_ALEN which is defined in linux/if_ether.h.
> Discovered when hacking on virtio-over-pci patches.
> 
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>

Applied, thanks.

Re: [PATCH] virtio: add missing include to virtio_net.h

[Rusty Russell]

On Wed, 29 Apr 2009 01:16:54 am Grant Likely wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
>
> virtio_net.h uses the macro ETH_ALEN which is defined in linux/if_ether.h.
> Discovered when hacking on virtio-over-pci patches.

Thanks, I've applied this.

Rusty.

Re: [PATCH] virtio: add missing include to virtio_net.h

[David Miller]

From: Rusty Russell <rusty@rustcorp.com.au>
Date: Tue, 5 May 2009 13:54:22 +0930

> On Wed, 29 Apr 2009 01:16:54 am Grant Likely wrote:
>> From: Grant Likely <grant.likely@secretlab.ca>
>>
>> virtio_net.h uses the macro ETH_ALEN which is defined in linux/if_ether.h.
>> Discovered when hacking on virtio-over-pci patches.
> 
> Thanks, I've applied this.

Rusty, all of this is in net-2.6 already.

Thanks for paying attention! :-)