* v2.6.31-7381-g7fa0772: new build warnings: kmemcheck, __deprecated, hugetlb, radeon
@ 2009-09-22 16:34 Stefan Richter
2009-09-23 6:39 ` Johannes Berg
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Stefan Richter @ 2009-09-22 16:34 UTC (permalink / raw)
To: linux-kernel; +Cc: Vegard Nossum, Eric B Munson, Johannes Berg, Dave Airlie
Latest git compiles with extreme noise:
In file included from include/net/inet_connection_sock.h:23,
from include/linux/tcp.h:178,
from include/linux/ipv6.h:215,
from include/net/ipv6.h:16,
from include/linux/sunrpc/clnt.h:25,
from include/linux/nfs_fs.h:52,
from kernel/sysctl.c:48:
include/net/inet_sock.h: In function 'inet_reqsk_alloc':
include/net/inet_sock.h:208: warning: ISO C90 forbids mixed declarations
and code
Vegard, this is obviously caused by commit
45e3ff82708c65c895d5c5882aff17ecf62a80b5.
$ grep KMEMCH .config
CONFIG_HAVE_ARCH_KMEMCHECK=y
(I.e. CONFIG_KMEMCHECK is off.)
More kmemcheck bogosity:
CC net/core/skbuff.o
In file included from include/net/ip.h:30,
from include/linux/errqueue.h:27,
from net/core/skbuff.c:59:
include/net/inet_sock.h: In function 'inet_reqsk_alloc':
include/net/inet_sock.h:208: warning: ISO C90 forbids mixed declarations
and code
net/core/skbuff.c: In function '__alloc_skb':
net/core/skbuff.c:205: warning: ISO C90 forbids mixed declarations and code
net/core/skbuff.c:206: warning: ISO C90 forbids mixed declarations and code
net/core/skbuff.c:227: warning: ISO C90 forbids mixed declarations and code
net/core/skbuff.c:228: warning: ISO C90 forbids mixed declarations and code
net/core/skbuff.c: In function 'skb_clone':
net/core/skbuff.c:645: warning: ISO C90 forbids mixed declarations and code
net/core/skbuff.c:646: warning: ISO C90 forbids mixed declarations and code
This one is older:
CC net/ethernet/eth.o
[...kmemcheck noise from inet_sock.h:208, and then...:]
net/ethernet/eth.c: At top level:
net/ethernet/eth.c:402: warning: 'print_mac' is deprecated (declared at
net/ethernet/eth.c:398)
net/ethernet/eth.c:402: warning: 'print_mac' is deprecated (declared at
net/ethernet/eth.c:398)
Obviously added by b5eb0589937eae2d58fca17fa45ed44152e772ed.
Johannes, can't the __deprecated logic be suppressed when print_mac is
used in EXPORT_SYMBOL?
Next one:
CC mm/mmap.o
mm/mmap.c: In function 'do_mmap_pgoff':
mm/mmap.c:953: warning: unused variable 'user'
Eric, this was added by 4e52780d41a741fb4861ae1df2413dd816ec11b1.
$ grep HUGETLB .config
# CONFIG_HUGETLBFS is not set
# CONFIG_HUGETLB_PAGE is not set
Next one:
CC [M] drivers/gpu/drm/radeon/radeon_ttm.o
drivers/gpu/drm/radeon/radeon_ttm.c: In function 'radeon_ttm_debugfs_init':
drivers/gpu/drm/radeon/radeon_ttm.c:714: warning: unused variable 'i'
drivers/gpu/drm/radeon/radeon_ttm.c: At top level:
drivers/gpu/drm/radeon/radeon_ttm.c:692: warning:
'radeon_mem_types_list' defined but not used
drivers/gpu/drm/radeon/radeon_ttm.c:693: warning:
'radeon_mem_types_names' defined but not used
Dave, added by fa8a123855e20068204982596b8fafceb1a67f0b.
$ grep -e RADEON -e DEBUG_FS .config
CONFIG_DRM_RADEON=m
CONFIG_FB_RADEON=y
CONFIG_FB_RADEON_I2C=y
# CONFIG_FB_RADEON_BACKLIGHT is not set
# CONFIG_FB_RADEON_DEBUG is not set
# CONFIG_DEBUG_FS is not set
--
Stefan Richter
-=====-==--= =--= =-==-
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: v2.6.31-7381-g7fa0772: new build warnings: kmemcheck, __deprecated, hugetlb, radeon
2009-09-22 16:34 v2.6.31-7381-g7fa0772: new build warnings: kmemcheck, __deprecated, hugetlb, radeon Stefan Richter
@ 2009-09-23 6:39 ` Johannes Berg
2009-09-23 7:19 ` Jean Delvare
2009-09-23 7:20 ` Pekka Enberg
2 siblings, 0 replies; 7+ messages in thread
From: Johannes Berg @ 2009-09-23 6:39 UTC (permalink / raw)
To: Stefan Richter; +Cc: linux-kernel, Vegard Nossum, Eric B Munson, Dave Airlie
[-- Attachment #1: Type: text/plain, Size: 676 bytes --]
On Tue, 2009-09-22 at 18:34 +0200, Stefan Richter wrote:
> This one is older:
>
> CC net/ethernet/eth.o
> [...kmemcheck noise from inet_sock.h:208, and then...:]
> net/ethernet/eth.c: At top level:
> net/ethernet/eth.c:402: warning: 'print_mac' is deprecated (declared at
> net/ethernet/eth.c:398)
> net/ethernet/eth.c:402: warning: 'print_mac' is deprecated (declared at
> net/ethernet/eth.c:398)
>
> Obviously added by b5eb0589937eae2d58fca17fa45ed44152e772ed.
> Johannes, can't the __deprecated logic be suppressed when print_mac is
> used in EXPORT_SYMBOL?
Not easily. But then we've already removed it completely by now afaik.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: v2.6.31-7381-g7fa0772: new build warnings: kmemcheck, __deprecated, hugetlb, radeon
2009-09-22 16:34 v2.6.31-7381-g7fa0772: new build warnings: kmemcheck, __deprecated, hugetlb, radeon Stefan Richter
2009-09-23 6:39 ` Johannes Berg
@ 2009-09-23 7:19 ` Jean Delvare
2009-09-23 7:21 ` Pekka Enberg
2009-09-23 8:19 ` Jean Delvare
2009-09-23 7:20 ` Pekka Enberg
2 siblings, 2 replies; 7+ messages in thread
From: Jean Delvare @ 2009-09-23 7:19 UTC (permalink / raw)
To: Stefan Richter
Cc: linux-kernel, Vegard Nossum, Eric B Munson, Johannes Berg,
Dave Airlie, Linus Torvalds
Hi Stefan,
On Tue, 22 Sep 2009 18:34:16 +0200, Stefan Richter wrote:
> Latest git compiles with extreme noise:
>
> In file included from include/net/inet_connection_sock.h:23,
> from include/linux/tcp.h:178,
> from include/linux/ipv6.h:215,
> from include/net/ipv6.h:16,
> from include/linux/sunrpc/clnt.h:25,
> from include/linux/nfs_fs.h:52,
> from kernel/sysctl.c:48:
> include/net/inet_sock.h: In function 'inet_reqsk_alloc':
> include/net/inet_sock.h:208: warning: ISO C90 forbids mixed declarations
> and code
>
> Vegard, this is obviously caused by commit
> 45e3ff82708c65c895d5c5882aff17ecf62a80b5.
Actually not, it's caused by commit
181f7c5dd3832763bdf2756b6d2d8a49bdf12791
(kmemcheck: add missing braces to do-while in kmemcheck_annotate_bitfield)
And the fix would be:
From: Jean Delvare <khali@linux-fr.org>
Subject: Fix build warning in kmemcheck_annotate_bitfield
Fix the following build warning:
include/net/inet_sock.h: In function 'inet_reqsk_alloc':
include/net/inet_sock.h:208: warning: ISO C90 forbids mixed declarations
and code
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
---
include/linux/kmemcheck.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- linux-2.6.32-pre.orig/include/linux/kmemcheck.h 2009-09-23 08:19:34.000000000 +0200
+++ linux-2.6.32-pre/include/linux/kmemcheck.h 2009-09-23 09:05:30.000000000 +0200
@@ -145,10 +145,12 @@ static inline bool kmemcheck_is_obj_init
#define kmemcheck_annotate_bitfield(ptr, name) \
do { \
+ int _n; \
+ \
if (!ptr) \
break; \
\
- int _n = (long) &((ptr)->name##_end) \
+ _n = (long) &((ptr)->name##_end) \
- (long) &((ptr)->name##_begin); \
BUILD_BUG_ON(_n < 0); \
\
--
Jean Delvare
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: v2.6.31-7381-g7fa0772: new build warnings: kmemcheck, __deprecated, hugetlb, radeon
2009-09-23 7:19 ` Jean Delvare
@ 2009-09-23 7:21 ` Pekka Enberg
2009-09-23 15:13 ` Stefan Richter
2009-09-23 8:19 ` Jean Delvare
1 sibling, 1 reply; 7+ messages in thread
From: Pekka Enberg @ 2009-09-23 7:21 UTC (permalink / raw)
To: Jean Delvare
Cc: Stefan Richter, linux-kernel, Vegard Nossum, Eric B Munson,
Johannes Berg, Dave Airlie, Linus Torvalds
On Wed, Sep 23, 2009 at 10:19 AM, Jean Delvare <khali@linux-fr.org> wrote:
> Hi Stefan,
>
> On Tue, 22 Sep 2009 18:34:16 +0200, Stefan Richter wrote:
>> Latest git compiles with extreme noise:
>>
>> In file included from include/net/inet_connection_sock.h:23,
>> from include/linux/tcp.h:178,
>> from include/linux/ipv6.h:215,
>> from include/net/ipv6.h:16,
>> from include/linux/sunrpc/clnt.h:25,
>> from include/linux/nfs_fs.h:52,
>> from kernel/sysctl.c:48:
>> include/net/inet_sock.h: In function 'inet_reqsk_alloc':
>> include/net/inet_sock.h:208: warning: ISO C90 forbids mixed declarations
>> and code
>>
>> Vegard, this is obviously caused by commit
>> 45e3ff82708c65c895d5c5882aff17ecf62a80b5.
>
> Actually not, it's caused by commit
> 181f7c5dd3832763bdf2756b6d2d8a49bdf12791
> (kmemcheck: add missing braces to do-while in kmemcheck_annotate_bitfield)
>
> And the fix would be:
>
> From: Jean Delvare <khali@linux-fr.org>
> Subject: Fix build warning in kmemcheck_annotate_bitfield
>
> Fix the following build warning:
>
> include/net/inet_sock.h: In function 'inet_reqsk_alloc':
> include/net/inet_sock.h:208: warning: ISO C90 forbids mixed declarations
> and code
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
> ---
> include/linux/kmemcheck.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> --- linux-2.6.32-pre.orig/include/linux/kmemcheck.h 2009-09-23 08:19:34.000000000 +0200
> +++ linux-2.6.32-pre/include/linux/kmemcheck.h 2009-09-23 09:05:30.000000000 +0200
> @@ -145,10 +145,12 @@ static inline bool kmemcheck_is_obj_init
>
> #define kmemcheck_annotate_bitfield(ptr, name) \
> do { \
> + int _n; \
> + \
> if (!ptr) \
> break; \
> \
> - int _n = (long) &((ptr)->name##_end) \
> + _n = (long) &((ptr)->name##_end) \
> - (long) &((ptr)->name##_begin); \
> BUILD_BUG_ON(_n < 0); \
> \
Oh, I was looking at an old version. The fix looks good to me, thanks Jean!
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: v2.6.31-7381-g7fa0772: new build warnings: kmemcheck, __deprecated, hugetlb, radeon
2009-09-23 7:21 ` Pekka Enberg
@ 2009-09-23 15:13 ` Stefan Richter
0 siblings, 0 replies; 7+ messages in thread
From: Stefan Richter @ 2009-09-23 15:13 UTC (permalink / raw)
To: Pekka Enberg
Cc: Jean Delvare, linux-kernel, Vegard Nossum, Eric B Munson,
Johannes Berg, Dave Airlie, Linus Torvalds
Pekka Enberg wrote:
> On Wed, Sep 23, 2009 at 10:19 AM, Jean Delvare <khali@linux-fr.org> wrote:
[...]
>> --- linux-2.6.32-pre.orig/include/linux/kmemcheck.h 2009-09-23 08:19:34.000000000 +0200
>> +++ linux-2.6.32-pre/include/linux/kmemcheck.h 2009-09-23 09:05:30.000000000 +0200
>> @@ -145,10 +145,12 @@ static inline bool kmemcheck_is_obj_init
>>
>> #define kmemcheck_annotate_bitfield(ptr, name) \
>> do { \
>> + int _n; \
>> + \
>> if (!ptr) \
>> break; \
>> \
>> - int _n = (long) &((ptr)->name##_end) \
>> + _n = (long) &((ptr)->name##_end) \
>> - (long) &((ptr)->name##_begin); \
>> BUILD_BUG_ON(_n < 0); \
>> \
>
> Oh, I was looking at an old version. The fix looks good to me, thanks Jean!
>
> Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Things have been set into motion already, see akpm's comment to thread
"[PATCH] kmemcheck: clean up kmemcheck_annotate_bitfield",
http://lkml.org/lkml/2009/9/22/585
--
Stefan Richter
-=====-==--= =--= =-===
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: v2.6.31-7381-g7fa0772: new build warnings: kmemcheck, __deprecated, hugetlb, radeon
2009-09-23 7:19 ` Jean Delvare
2009-09-23 7:21 ` Pekka Enberg
@ 2009-09-23 8:19 ` Jean Delvare
1 sibling, 0 replies; 7+ messages in thread
From: Jean Delvare @ 2009-09-23 8:19 UTC (permalink / raw)
To: Stefan Richter
Cc: linux-kernel, Vegard Nossum, Eric B Munson, Johannes Berg,
Dave Airlie, Linus Torvalds
On Wed, 23 Sep 2009 09:19:58 +0200, Jean Delvare wrote:
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
Oops, I messed up there. That was supposed to be a simple Cc:, bad
copy-and-paste, sorry. Please fix before pushing upstream.
--
Jean Delvare
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: v2.6.31-7381-g7fa0772: new build warnings: kmemcheck, __deprecated, hugetlb, radeon
2009-09-22 16:34 v2.6.31-7381-g7fa0772: new build warnings: kmemcheck, __deprecated, hugetlb, radeon Stefan Richter
2009-09-23 6:39 ` Johannes Berg
2009-09-23 7:19 ` Jean Delvare
@ 2009-09-23 7:20 ` Pekka Enberg
2 siblings, 0 replies; 7+ messages in thread
From: Pekka Enberg @ 2009-09-23 7:20 UTC (permalink / raw)
To: Stefan Richter
Cc: linux-kernel, Vegard Nossum, Eric B Munson, Johannes Berg,
Dave Airlie
On Tue, Sep 22, 2009 at 7:34 PM, Stefan Richter
<stefanr@s5r6.in-berlin.de> wrote:
> Latest git compiles with extreme noise:
>
> In file included from include/net/inet_connection_sock.h:23,
> from include/linux/tcp.h:178,
> from include/linux/ipv6.h:215,
> from include/net/ipv6.h:16,
> from include/linux/sunrpc/clnt.h:25,
> from include/linux/nfs_fs.h:52,
> from kernel/sysctl.c:48:
> include/net/inet_sock.h: In function 'inet_reqsk_alloc':
> include/net/inet_sock.h:208: warning: ISO C90 forbids mixed declarations and
> code
>
> Vegard, this is obviously caused by commit
> 45e3ff82708c65c895d5c5882aff17ecf62a80b5.
>
> $ grep KMEMCH .config
> CONFIG_HAVE_ARCH_KMEMCHECK=y
>
> (I.e. CONFIG_KMEMCHECK is off.)
Curious, I haven't seen this before. Is it coming from the
BUILD_BUG_ON() in kmemcheck_annotate_bitfield()? I can't seem to spot
the error.
Pekka
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-09-23 15:14 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-22 16:34 v2.6.31-7381-g7fa0772: new build warnings: kmemcheck, __deprecated, hugetlb, radeon Stefan Richter
2009-09-23 6:39 ` Johannes Berg
2009-09-23 7:19 ` Jean Delvare
2009-09-23 7:21 ` Pekka Enberg
2009-09-23 15:13 ` Stefan Richter
2009-09-23 8:19 ` Jean Delvare
2009-09-23 7:20 ` Pekka Enberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox