From: Andrew Patterson <andrew.patterson@hp.com>
To: ying.huang@intel.com
Cc: prarit@redhat.com, andi@firstfloor.org,
linux-kernel@vger.kernel.org, jbarnes@virtuousgeek.org,
pci-linux@vger.kernel.org
Subject: [PATCH 3/5] PCI: maintain backwards compatibility with aer-inject user-land tool
Date: Mon, 12 Oct 2009 01:03:04 -0600 [thread overview]
Message-ID: <20091012070304.27029.14815.stgit@bob.kio> (raw)
In-Reply-To: <20091012070248.27029.78378.stgit@bob.kio>
PCI: maintain backwards compatibility with aer-inject user-land tool
Maintain backwards compatibility with the 0.1 version of the aer-inject
user-land tool.
Signed-off-by: Andrew Patterson<andrew.patterson@hp.com>
---
diff --git a/drivers/pci/pcie/aer/aer_inject.c b/drivers/pci/pcie/aer/aer_inject.c
index 5fc5b3e..ac0b5e7 100644
--- a/drivers/pci/pcie/aer/aer_inject.c
+++ b/drivers/pci/pcie/aer/aer_inject.c
@@ -23,10 +23,10 @@
#include <linux/pci.h>
#include <linux/fs.h>
#include <linux/uaccess.h>
+#include <linux/stddef.h>
#include "aerdrv.h"
struct aer_error_inj {
- u16 domain;
u8 bus;
u8 dev;
u8 fn;
@@ -36,6 +36,7 @@ struct aer_error_inj {
u32 header_log1;
u32 header_log2;
u32 header_log3;
+ u16 domain;
};
struct aer_error {
@@ -431,10 +432,11 @@ static ssize_t aer_inject_write(struct file *filp, const char __user *ubuf,
if (!capable(CAP_SYS_ADMIN))
return -EPERM;
-
- if (usize != sizeof(struct aer_error_inj))
+ if (usize < offsetof(struct aer_error_inj, domain) ||
+ usize > sizeof(einj))
return -EINVAL;
+ memset(&einj, 0, sizeof(einj));
if (copy_from_user(&einj, ubuf, usize))
return -EFAULT;
next prev parent reply other threads:[~2009-10-12 7:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 7:02 [PATCH 0/5] PCI: add domain support to aer_inject and other fixups Andrew Patterson
2009-10-12 7:02 ` [PATCH 1/5] PCI: add pci_get_domain_bus_and_slot function Andrew Patterson
2009-10-12 7:02 ` [PATCH 2/5] PCI: add support for PCI domains to aer_inject Andrew Patterson
2009-10-12 7:03 ` Andrew Patterson [this message]
2009-10-12 7:49 ` [PATCH 3/5] PCI: maintain backwards compatibility with aer-inject user-land tool Huang Ying
2009-10-12 7:03 ` [PATCH 4/5] PCI: use better error return values in aer_inject Andrew Patterson
2009-10-12 7:03 ` [PATCH 5/5] PCI: fix memory leak " Andrew Patterson
2009-10-12 7:44 ` Huang Ying
2009-10-26 21:21 ` Jesse Barnes
2009-10-27 0:43 ` Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012070304.27029.14815.stgit@bob.kio \
--to=andrew.patterson@hp.com \
--cc=andi@firstfloor.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pci-linux@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox