From: Andrew Patterson <andrew.patterson@hp.com>
To: ying.huang@intel.com
Cc: prarit@redhat.com, andi@firstfloor.org,
linux-kernel@vger.kernel.org, jbarnes@virtuousgeek.org,
pci-linux@vger.kernel.org
Subject: [PATCH 4/5] PCI: use better error return values in aer_inject
Date: Mon, 12 Oct 2009 01:03:09 -0600 [thread overview]
Message-ID: <20091012070309.27029.80298.stgit@bob.kio> (raw)
In-Reply-To: <20091012070248.27029.78378.stgit@bob.kio>
PCI: use better error return values in aer_inject
Replaced some error return values in aer_inject. Use -ENODEV when we
can't find a device and -ENOTTY when the device does not support PCIe AER.
Signed-off-by: Andrew Patterson <andrew.patterson@hp.com>
---
diff --git a/drivers/pci/pcie/aer/aer_inject.c b/drivers/pci/pcie/aer/aer_inject.c
index ac0b5e7..da2ad6e 100644
--- a/drivers/pci/pcie/aer/aer_inject.c
+++ b/drivers/pci/pcie/aer/aer_inject.c
@@ -326,23 +326,23 @@ static int aer_inject(struct aer_error_inj *einj)
dev = pci_get_domain_bus_and_slot((int)einj->domain, einj->bus, devfn);
if (!dev)
- return -EINVAL;
+ return -ENODEV;
rpdev = pcie_find_root_port(dev);
if (!rpdev) {
- ret = -EINVAL;
+ ret = -ENOTTY;
goto out_put;
}
pos_cap_err = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ERR);
if (!pos_cap_err) {
- ret = -EIO;
+ ret = -ENOTTY;
goto out_put;
}
pci_read_config_dword(dev, pos_cap_err + PCI_ERR_UNCOR_SEVER, &sever);
rp_pos_cap_err = pci_find_ext_capability(rpdev, PCI_EXT_CAP_ID_ERR);
if (!rp_pos_cap_err) {
- ret = -EIO;
+ ret = -ENOTTY;
goto out_put;
}
next prev parent reply other threads:[~2009-10-12 7:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 7:02 [PATCH 0/5] PCI: add domain support to aer_inject and other fixups Andrew Patterson
2009-10-12 7:02 ` [PATCH 1/5] PCI: add pci_get_domain_bus_and_slot function Andrew Patterson
2009-10-12 7:02 ` [PATCH 2/5] PCI: add support for PCI domains to aer_inject Andrew Patterson
2009-10-12 7:03 ` [PATCH 3/5] PCI: maintain backwards compatibility with aer-inject user-land tool Andrew Patterson
2009-10-12 7:49 ` Huang Ying
2009-10-12 7:03 ` Andrew Patterson [this message]
2009-10-12 7:03 ` [PATCH 5/5] PCI: fix memory leak in aer_inject Andrew Patterson
2009-10-12 7:44 ` Huang Ying
2009-10-26 21:21 ` Jesse Barnes
2009-10-27 0:43 ` Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012070309.27029.80298.stgit@bob.kio \
--to=andrew.patterson@hp.com \
--cc=andi@firstfloor.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pci-linux@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox