From: Huang Ying <ying.huang@intel.com>
To: Andrew Patterson <andrew.patterson@hp.com>
Cc: "prarit@redhat.com" <prarit@redhat.com>,
"andi@firstfloor.org" <andi@firstfloor.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jbarnes@virtuousgeek.org" <jbarnes@virtuousgeek.org>,
"pci-linux@vger.kernel.org" <pci-linux@vger.kernel.org>
Subject: Re: [PATCH 5/5] PCI: fix memory leak in aer_inject
Date: Mon, 12 Oct 2009 15:44:30 +0800 [thread overview]
Message-ID: <1255333470.6047.141.camel@yhuang-dev.sh.intel.com> (raw)
In-Reply-To: <20091012070314.27029.35077.stgit@bob.kio>
On Mon, 2009-10-12 at 15:03 +0800, Andrew Patterson wrote:
> PCI: fix memory leak in aer_inject
>
> Fixed probable typo in aer_inject cleanup code resulting in a memory
> leak.
>
> Signed-off-by: Andrew Patterson <andrew.patterson@hp.com>
> ---
>
> diff --git a/drivers/pci/pcie/aer/aer_inject.c b/drivers/pci/pcie/aer/aer_inject.c
> index da2ad6e..2246bf7 100644
> --- a/drivers/pci/pcie/aer/aer_inject.c
> +++ b/drivers/pci/pcie/aer/aer_inject.c
> @@ -474,7 +474,7 @@ static void __exit aer_inject_exit(void)
> }
>
> spin_lock_irqsave(&inject_lock, flags);
> - list_for_each_entry_safe(err, err_next, &pci_bus_ops_list, list) {
> + list_for_each_entry_safe(err, err_next, &einjected, list) {
> list_del(&err->list);
> kfree(err);
> }
Thanks for the patch.
Acked-by: Huang Ying <ying.huang@intel.com>
Best Regards,
Huang Ying
next prev parent reply other threads:[~2009-10-12 7:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 7:02 [PATCH 0/5] PCI: add domain support to aer_inject and other fixups Andrew Patterson
2009-10-12 7:02 ` [PATCH 1/5] PCI: add pci_get_domain_bus_and_slot function Andrew Patterson
2009-10-12 7:02 ` [PATCH 2/5] PCI: add support for PCI domains to aer_inject Andrew Patterson
2009-10-12 7:03 ` [PATCH 3/5] PCI: maintain backwards compatibility with aer-inject user-land tool Andrew Patterson
2009-10-12 7:49 ` Huang Ying
2009-10-12 7:03 ` [PATCH 4/5] PCI: use better error return values in aer_inject Andrew Patterson
2009-10-12 7:03 ` [PATCH 5/5] PCI: fix memory leak " Andrew Patterson
2009-10-12 7:44 ` Huang Ying [this message]
2009-10-26 21:21 ` Jesse Barnes
2009-10-27 0:43 ` Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255333470.6047.141.camel@yhuang-dev.sh.intel.com \
--to=ying.huang@intel.com \
--cc=andi@firstfloor.org \
--cc=andrew.patterson@hp.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pci-linux@vger.kernel.org \
--cc=prarit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox