* [PATCH] Staging: dream: smd: smd_private: fix code style issues
@ 2010-03-15 3:29 Chihau Chau
2010-03-15 5:32 ` Pavel Machek
0 siblings, 1 reply; 4+ messages in thread
From: Chihau Chau @ 2010-03-15 3:29 UTC (permalink / raw)
To: gregkh; +Cc: pavel, devel, linux-kernel, Chihau Chau
From: Chihau Chau <chihau@gmail.com>
This put open braces '{' following structs on the same line.
Signed-off-by: Chihau Chau <chihau@gmail.com>
---
drivers/staging/dream/smd/smd_private.h | 21 +++++++--------------
1 files changed, 7 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/dream/smd/smd_private.h b/drivers/staging/dream/smd/smd_private.h
index c0eb3de..1b2e1c8 100644
--- a/drivers/staging/dream/smd/smd_private.h
+++ b/drivers/staging/dream/smd/smd_private.h
@@ -16,24 +16,21 @@
#ifndef _ARCH_ARM_MACH_MSM_MSM_SMD_PRIVATE_H_
#define _ARCH_ARM_MACH_MSM_MSM_SMD_PRIVATE_H_
-struct smem_heap_info
-{
+struct smem_heap_info {
unsigned initialized;
unsigned free_offset;
unsigned heap_remaining;
unsigned reserved;
};
-struct smem_heap_entry
-{
+struct smem_heap_entry {
unsigned allocated;
unsigned offset;
unsigned size;
unsigned reserved;
};
-struct smem_proc_comm
-{
+struct smem_proc_comm {
unsigned command;
unsigned status;
unsigned data1;
@@ -49,22 +46,19 @@ struct smem_proc_comm
#define VERSION_APPS 8
#define VERSION_MODEM 9
-struct smem_shared
-{
+struct smem_shared {
struct smem_proc_comm proc_comm[4];
unsigned version[32];
struct smem_heap_info heap_info;
struct smem_heap_entry heap_toc[128];
};
-struct smsm_shared
-{
+struct smsm_shared {
unsigned host;
unsigned state;
};
-struct smsm_interrupt_info
-{
+struct smsm_interrupt_info {
uint32_t aArm_en_mask;
uint32_t aArm_interrupts_pending;
uint32_t aArm_wakeup_reason;
@@ -108,8 +102,7 @@ void smsm_print_sleep_info(void);
#define SMEM_NUM_SMD_CHANNELS 64
-typedef enum
-{
+typedef enum {
/* fixed items */
SMEM_PROC_COMM = 0,
SMEM_HEAP_INFO,
--
1.5.6.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Staging: dream: smd: smd_private: fix code style issues
2010-03-15 3:29 [PATCH] Staging: dream: smd: smd_private: fix code style issues Chihau Chau
@ 2010-03-15 5:32 ` Pavel Machek
2010-04-10 18:09 ` Chihau Chau
0 siblings, 1 reply; 4+ messages in thread
From: Pavel Machek @ 2010-03-15 5:32 UTC (permalink / raw)
To: Chihau Chau, Greg KH; +Cc: gregkh, devel, linux-kernel
On Mon 2010-03-15 00:29:02, Chihau Chau wrote:
> From: Chihau Chau <chihau@gmail.com>
>
> This put open braces '{' following structs on the same line.
>
> Signed-off-by: Chihau Chau <chihau@gmail.com>
ACK.
> ---
> drivers/staging/dream/smd/smd_private.h | 21 +++++++--------------
> 1 files changed, 7 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/staging/dream/smd/smd_private.h b/drivers/staging/dream/smd/smd_private.h
> index c0eb3de..1b2e1c8 100644
> --- a/drivers/staging/dream/smd/smd_private.h
> +++ b/drivers/staging/dream/smd/smd_private.h
> @@ -16,24 +16,21 @@
> #ifndef _ARCH_ARM_MACH_MSM_MSM_SMD_PRIVATE_H_
> #define _ARCH_ARM_MACH_MSM_MSM_SMD_PRIVATE_H_
>
> -struct smem_heap_info
> -{
> +struct smem_heap_info {
> unsigned initialized;
> unsigned free_offset;
> unsigned heap_remaining;
> unsigned reserved;
> };
>
> -struct smem_heap_entry
> -{
> +struct smem_heap_entry {
> unsigned allocated;
> unsigned offset;
> unsigned size;
> unsigned reserved;
> };
>
> -struct smem_proc_comm
> -{
> +struct smem_proc_comm {
> unsigned command;
> unsigned status;
> unsigned data1;
> @@ -49,22 +46,19 @@ struct smem_proc_comm
> #define VERSION_APPS 8
> #define VERSION_MODEM 9
>
> -struct smem_shared
> -{
> +struct smem_shared {
> struct smem_proc_comm proc_comm[4];
> unsigned version[32];
> struct smem_heap_info heap_info;
> struct smem_heap_entry heap_toc[128];
> };
>
> -struct smsm_shared
> -{
> +struct smsm_shared {
> unsigned host;
> unsigned state;
> };
>
> -struct smsm_interrupt_info
> -{
> +struct smsm_interrupt_info {
> uint32_t aArm_en_mask;
> uint32_t aArm_interrupts_pending;
> uint32_t aArm_wakeup_reason;
> @@ -108,8 +102,7 @@ void smsm_print_sleep_info(void);
>
> #define SMEM_NUM_SMD_CHANNELS 64
>
> -typedef enum
> -{
> +typedef enum {
> /* fixed items */
> SMEM_PROC_COMM = 0,
> SMEM_HEAP_INFO,
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Staging: dream: smd: smd_private: fix code style issues
2010-03-15 5:32 ` Pavel Machek
@ 2010-04-10 18:09 ` Chihau Chau
2010-04-28 18:42 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Chihau Chau @ 2010-04-10 18:09 UTC (permalink / raw)
To: Pavel Machek; +Cc: Greg KH, gregkh, devel, linux-kernel
So, What about this patch? Greg?
2010/3/15 Pavel Machek <pavel@ucw.cz>:
> On Mon 2010-03-15 00:29:02, Chihau Chau wrote:
>> From: Chihau Chau <chihau@gmail.com>
>>
>> This put open braces '{' following structs on the same line.
>>
>> Signed-off-by: Chihau Chau <chihau@gmail.com>
>
> ACK.
>
>> ---
>> drivers/staging/dream/smd/smd_private.h | 21 +++++++--------------
>> 1 files changed, 7 insertions(+), 14 deletions(-)
>>
>> diff --git a/drivers/staging/dream/smd/smd_private.h b/drivers/staging/dream/smd/smd_private.h
>> index c0eb3de..1b2e1c8 100644
>> --- a/drivers/staging/dream/smd/smd_private.h
>> +++ b/drivers/staging/dream/smd/smd_private.h
>> @@ -16,24 +16,21 @@
>> #ifndef _ARCH_ARM_MACH_MSM_MSM_SMD_PRIVATE_H_
>> #define _ARCH_ARM_MACH_MSM_MSM_SMD_PRIVATE_H_
>>
>> -struct smem_heap_info
>> -{
>> +struct smem_heap_info {
>> unsigned initialized;
>> unsigned free_offset;
>> unsigned heap_remaining;
>> unsigned reserved;
>> };
>>
>> -struct smem_heap_entry
>> -{
>> +struct smem_heap_entry {
>> unsigned allocated;
>> unsigned offset;
>> unsigned size;
>> unsigned reserved;
>> };
>>
>> -struct smem_proc_comm
>> -{
>> +struct smem_proc_comm {
>> unsigned command;
>> unsigned status;
>> unsigned data1;
>> @@ -49,22 +46,19 @@ struct smem_proc_comm
>> #define VERSION_APPS 8
>> #define VERSION_MODEM 9
>>
>> -struct smem_shared
>> -{
>> +struct smem_shared {
>> struct smem_proc_comm proc_comm[4];
>> unsigned version[32];
>> struct smem_heap_info heap_info;
>> struct smem_heap_entry heap_toc[128];
>> };
>>
>> -struct smsm_shared
>> -{
>> +struct smsm_shared {
>> unsigned host;
>> unsigned state;
>> };
>>
>> -struct smsm_interrupt_info
>> -{
>> +struct smsm_interrupt_info {
>> uint32_t aArm_en_mask;
>> uint32_t aArm_interrupts_pending;
>> uint32_t aArm_wakeup_reason;
>> @@ -108,8 +102,7 @@ void smsm_print_sleep_info(void);
>>
>> #define SMEM_NUM_SMD_CHANNELS 64
>>
>> -typedef enum
>> -{
>> +typedef enum {
>> /* fixed items */
>> SMEM_PROC_COMM = 0,
>> SMEM_HEAP_INFO,
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>
--
Chihau Chau
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-04-28 18:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-15 3:29 [PATCH] Staging: dream: smd: smd_private: fix code style issues Chihau Chau
2010-03-15 5:32 ` Pavel Machek
2010-04-10 18:09 ` Chihau Chau
2010-04-28 18:42 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox