* [PATCH] net: ax25: fix information leak to userland harder
@ 2011-01-12 5:40 Kees Cook
2011-01-12 8:34 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Kees Cook @ 2011-01-12 5:40 UTC (permalink / raw)
To: linux-kernel
Cc: Brad Spengler, Vasiliy Kulikov, David S. Miller,
netdev@vger.kernel.org Joerg Reuter, Ralf Baechle
Commit fe10ae53384e48c51996941b7720ee16995cbcb7 adds a memset() to clear
the structure being sent back to userspace, but accidentally used the
wrong size.
Reported-by: Brad Spengler <spender@grsecurity.net>
Signed-off-by: Kees Cook <kees.cook@canonical.com>
Cc: stable@kernel.org
---
net/ax25/af_ax25.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
index bb86d29..6da5dae 100644
--- a/net/ax25/af_ax25.c
+++ b/net/ax25/af_ax25.c
@@ -1392,7 +1392,7 @@ static int ax25_getname(struct socket *sock, struct sockaddr *uaddr,
ax25_cb *ax25;
int err = 0;
- memset(fsa, 0, sizeof(fsa));
+ memset(fsa, 0, sizeof(*fsa));
lock_sock(sk);
ax25 = ax25_sk(sk);
--
1.7.2.3
--
Kees Cook
Ubuntu Security Team
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: ax25: fix information leak to userland harder
2011-01-12 5:40 [PATCH] net: ax25: fix information leak to userland harder Kees Cook
@ 2011-01-12 8:34 ` David Miller
2011-01-12 8:35 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2011-01-12 8:34 UTC (permalink / raw)
To: kees.cook; +Cc: linux-kernel, spender, segooon, jreuter, ralf
From: Kees Cook <kees.cook@canonical.com>
Date: Tue, 11 Jan 2011 21:40:22 -0800
> Commit fe10ae53384e48c51996941b7720ee16995cbcb7 adds a memset() to clear
> the structure being sent back to userspace, but accidentally used the
> wrong size.
>
> Reported-by: Brad Spengler <spender@grsecurity.net>
> Signed-off-by: Kees Cook <kees.cook@canonical.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: ax25: fix information leak to userland harder
2011-01-12 8:34 ` David Miller
@ 2011-01-12 8:35 ` David Miller
2011-01-12 14:01 ` Kees Cook
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2011-01-12 8:35 UTC (permalink / raw)
To: kees.cook; +Cc: linux-kernel, spender, segooon, jreuter, ralf
BTW, in the future please CC: netdev@vger.kernel.org on all networking
patches.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: ax25: fix information leak to userland harder
2011-01-12 8:35 ` David Miller
@ 2011-01-12 14:01 ` Kees Cook
0 siblings, 0 replies; 4+ messages in thread
From: Kees Cook @ 2011-01-12 14:01 UTC (permalink / raw)
To: David Miller; +Cc: linux-kernel, spender, segooon, jreuter, ralf
Hi David,
On Wed, Jan 12, 2011 at 12:35:31AM -0800, David Miller wrote:
> BTW, in the future please CC: netdev@vger.kernel.org on all networking
> patches.
Yeah, I meant to, but I think my mail client ate the address somehow. Sorry about
that!
-Kees
--
Kees Cook
Ubuntu Security Team
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-01-12 14:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-12 5:40 [PATCH] net: ax25: fix information leak to userland harder Kees Cook
2011-01-12 8:34 ` David Miller
2011-01-12 8:35 ` David Miller
2011-01-12 14:01 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox