* [PATCH 2/2] Documentation: add docs for 88pm80x dt
@ 2012-12-05 5:42 Qing Xu
2012-12-05 22:55 ` Grant Likely
0 siblings, 1 reply; 3+ messages in thread
From: Qing Xu @ 2012-12-05 5:42 UTC (permalink / raw)
To: qingx, rob, sameo, haojian.zhuang, grant.likely, rob.herring,
zhouqiao, cxie4, linux-kernel
From: Qing Xu <qingx@marvell.com>
Signed-off-by: Qing Xu <qingx@marvell.com>
---
Documentation/devicetree/bindings/mfd/88pm80x.txt | 52 +++++++++++++++++++++
1 files changed, 52 insertions(+), 0 deletions(-)
create mode 100644 Documentation/devicetree/bindings/mfd/88pm80x.txt
diff --git a/Documentation/devicetree/bindings/mfd/88pm80x.txt b/Documentation/devicetree/bindings/mfd/88pm80x.txt
new file mode 100644
index 0000000..8a0ed07
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/88pm80x.txt
@@ -0,0 +1,52 @@
+* Marvell 88pm80x Power Management IC
+
+Required parent device properties:
+- compatible : "marvell,88pm80x"
+- reg : the I2C slave address for the 88pm80x chip
+- interrupts : IRQ line for the 88pm80x chip
+- interrupt-controller: describes the 88pm80x as an interrupt controller (has its own domain)
+- #interrupt-cells : should be 1.
+ - The cell is the 88pm80x local IRQ number
+
+Optional parent device properties:
+- marvell,88pm80x-irqmode: inicates whether interrupt status is cleared by read
+- marvell,88pm80x-poweraddr: 88pm80x are multi-chips solution. <reg> stores the I2C address
+ of one chip, and this property stores the I2C address of
+ power related chip.
+- marvell,88pm80x-gpadcaddr: 88pm80x are multi-chips solution. <reg> stores the I2C address
+ of one chip, and this property stores the I2C address of
+ gpadc related chip.
+
+88pm80x consists of various groups of sub-devices:
+
+Device Supply Names Description
+------ ------------ -----------
+88pm80x-onkey : : On key
+88pm80x-rtc : : RTC
+
+Example:
+ pmic: 88pm800@30 {
+ compatible = "marvell,88pm80x";
+ reg = <0x30>;
+ interrupts = <4>;
+ interrupt-parent = <&intc>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+
+ marvell,88pm80x-irqmode = 0;
+ marvell,88pm80x-poweraddr = <0x31>;
+ marvell,88pm80x-gpadcaddr = <0x32>;
+ };
+
+
+ pmic: 88pm805@38 {
+ compatible = "marvell,88pm80x";
+ reg = <0x38>;
+ interrupts = <124>;
+ interrupt-parent = <&gpio>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+
+ marvell,88pm80x-irqmode = 0;
+ };
+
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 2/2] Documentation: add docs for 88pm80x dt
2012-12-05 5:42 [PATCH 2/2] Documentation: add docs for 88pm80x dt Qing Xu
@ 2012-12-05 22:55 ` Grant Likely
2012-12-06 1:58 ` Qing Xu
0 siblings, 1 reply; 3+ messages in thread
From: Grant Likely @ 2012-12-05 22:55 UTC (permalink / raw)
To: Qing Xu, qingx, rob, sameo, haojian.zhuang, rob.herring, zhouqiao,
cxie4, linux-kernel
On Wed, 5 Dec 2012 13:42:00 +0800, Qing Xu <qingx@marvell.com> wrote:
> From: Qing Xu <qingx@marvell.com>
>
> Signed-off-by: Qing Xu <qingx@marvell.com>
No commit text?
This patch needs to be squashed together with the patch that changes the
driver. There is no value in separating them.
> ---
> Documentation/devicetree/bindings/mfd/88pm80x.txt | 52 +++++++++++++++++++++
> 1 files changed, 52 insertions(+), 0 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mfd/88pm80x.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/88pm80x.txt b/Documentation/devicetree/bindings/mfd/88pm80x.txt
> new file mode 100644
> index 0000000..8a0ed07
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/88pm80x.txt
> @@ -0,0 +1,52 @@
> +* Marvell 88pm80x Power Management IC
> +
> +Required parent device properties:
> +- compatible : "marvell,88pm80x"
> +- reg : the I2C slave address for the 88pm80x chip
> +- interrupts : IRQ line for the 88pm80x chip
> +- interrupt-controller: describes the 88pm80x as an interrupt controller (has its own domain)
> +- #interrupt-cells : should be 1.
> + - The cell is the 88pm80x local IRQ number
> +
> +Optional parent device properties:
> +- marvell,88pm80x-irqmode: inicates whether interrupt status is cleared by read
> +- marvell,88pm80x-poweraddr: 88pm80x are multi-chips solution. <reg> stores the I2C address
> + of one chip, and this property stores the I2C address of
> + power related chip.
> +- marvell,88pm80x-gpadcaddr: 88pm80x are multi-chips solution. <reg> stores the I2C address
> + of one chip, and this property stores the I2C address of
> + gpadc related chip.
If it is multichip, then I would expect either a separate node for each
chip and these properties use phandles (instead of i2c addresses) to
point to the other chip nodes.
Alternately, if the cluster is described using a single node, then you
can put all three i2c addresses into the 'reg' property.
g.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] Documentation: add docs for 88pm80x dt
2012-12-05 22:55 ` Grant Likely
@ 2012-12-06 1:58 ` Qing Xu
0 siblings, 0 replies; 3+ messages in thread
From: Qing Xu @ 2012-12-06 1:58 UTC (permalink / raw)
To: Grant Likely
Cc: rob@landley.net, sameo@linux.intel.com, haojian.zhuang@gmail.com,
rob.herring@calxeda.com, Qiao Zhou, Chao Xie,
linux-kernel@vger.kernel.org
On 12/06/2012 06:55 AM, Grant Likely wrote:
> On Wed, 5 Dec 2012 13:42:00 +0800, Qing Xu <qingx@marvell.com> wrote:
>> From: Qing Xu <qingx@marvell.com>
>>
>> Signed-off-by: Qing Xu <qingx@marvell.com>
> No commit text?
>
> This patch needs to be squashed together with the patch that changes the
> driver. There is no value in separating them.
>
>> ---
>> Documentation/devicetree/bindings/mfd/88pm80x.txt | 52 +++++++++++++++++++++
>> 1 files changed, 52 insertions(+), 0 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/mfd/88pm80x.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/88pm80x.txt b/Documentation/devicetree/bindings/mfd/88pm80x.txt
>> new file mode 100644
>> index 0000000..8a0ed07
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/88pm80x.txt
>> @@ -0,0 +1,52 @@
>> +* Marvell 88pm80x Power Management IC
>> +
>> +Required parent device properties:
>> +- compatible : "marvell,88pm80x"
>> +- reg : the I2C slave address for the 88pm80x chip
>> +- interrupts : IRQ line for the 88pm80x chip
>> +- interrupt-controller: describes the 88pm80x as an interrupt controller (has its own domain)
>> +- #interrupt-cells : should be 1.
>> + - The cell is the 88pm80x local IRQ number
>> +
>> +Optional parent device properties:
>> +- marvell,88pm80x-irqmode: inicates whether interrupt status is cleared by read
>> +- marvell,88pm80x-poweraddr: 88pm80x are multi-chips solution. <reg> stores the I2C address
>> + of one chip, and this property stores the I2C address of
>> + power related chip.
>> +- marvell,88pm80x-gpadcaddr: 88pm80x are multi-chips solution. <reg> stores the I2C address
>> + of one chip, and this property stores the I2C address of
>> + gpadc related chip.
> If it is multichip, then I would expect either a separate node for each
> chip and these properties use phandles (instead of i2c addresses) to
> point to the other chip nodes.
>
> Alternately, if the cluster is described using a single node, then you
> can put all three i2c addresses into the 'reg' property.
>
> g.
combined to one patch. please help review again. Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-06 1:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-05 5:42 [PATCH 2/2] Documentation: add docs for 88pm80x dt Qing Xu
2012-12-05 22:55 ` Grant Likely
2012-12-06 1:58 ` Qing Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox