* [PATCH 5/7] gpio: tc3589x: remove unnecessary platform_set_drvdata()
@ 2013-05-06 3:32 Jingoo Han
2013-05-07 8:16 ` Lee Jones
2013-05-30 16:46 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2013-05-06 3:32 UTC (permalink / raw)
To: 'Grant Likely'
Cc: 'Linus Walleij', linux-kernel, Jingoo Han,
'Lee Jones'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/gpio/gpio-tc3589x.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/gpio/gpio-tc3589x.c b/drivers/gpio/gpio-tc3589x.c
index d34d80d..4a5de27 100644
--- a/drivers/gpio/gpio-tc3589x.c
+++ b/drivers/gpio/gpio-tc3589x.c
@@ -407,7 +407,6 @@ static int tc3589x_gpio_remove(struct platform_device *pdev)
free_irq(irq, tc3589x_gpio);
- platform_set_drvdata(pdev, NULL);
kfree(tc3589x_gpio);
return 0;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 5/7] gpio: tc3589x: remove unnecessary platform_set_drvdata()
2013-05-06 3:32 [PATCH 5/7] gpio: tc3589x: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-07 8:16 ` Lee Jones
2013-05-30 16:46 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2013-05-07 8:16 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'Grant Likely', 'Linus Walleij', linux-kernel
On Mon, 06 May 2013, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/gpio/gpio-tc3589x.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tc3589x.c b/drivers/gpio/gpio-tc3589x.c
> index d34d80d..4a5de27 100644
> --- a/drivers/gpio/gpio-tc3589x.c
> +++ b/drivers/gpio/gpio-tc3589x.c
> @@ -407,7 +407,6 @@ static int tc3589x_gpio_remove(struct platform_device *pdev)
>
> free_irq(irq, tc3589x_gpio);
>
> - platform_set_drvdata(pdev, NULL);
> kfree(tc3589x_gpio);
>
> return 0;
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 5/7] gpio: tc3589x: remove unnecessary platform_set_drvdata()
2013-05-06 3:32 [PATCH 5/7] gpio: tc3589x: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-07 8:16 ` Lee Jones
@ 2013-05-30 16:46 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2013-05-30 16:46 UTC (permalink / raw)
To: Jingoo Han; +Cc: Grant Likely, linux-kernel@vger.kernel.org, Lee Jones
On Mon, May 6, 2013 at 5:32 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Patch applied with Lee's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-30 16:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 3:32 [PATCH 5/7] gpio: tc3589x: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-07 8:16 ` Lee Jones
2013-05-30 16:46 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox