From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Davide Ciminaghi <ciminaghi@gnudd.com>,
Stephen Warren <swarren@wwwdotorg.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] regmap: Make regmap-mmio usable from different contexts
Date: Thu, 23 May 2013 09:05:03 -0500 [thread overview]
Message-ID: <20130523140503.GD2412@sirena.org.uk> (raw)
In-Reply-To: <1369314377-22873-2-git-send-email-lars@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 621 bytes --]
On Thu, May 23, 2013 at 03:06:16PM +0200, Lars-Peter Clausen wrote:
> This patch updates the adds a flags parameter to the regmap lock and unlock
> callbacks and uses spin_lock_irqsave() and spin_unlock_restore() for the mmio
> case. This allows us to use regmap-mmio from different contexts.
This seems really invasive, why not just have the lock that gets passed
in point to a struct which has both the lock and the flags? As far as
the core is concerned the lock is just whatever data is required to do
the locking, the fact that it's actually two values is an implementation
detail of this locking implementation.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-05-23 14:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 13:06 [PATCH 1/2] regmap: regcache: Fixup locking for custom lock callbacks Lars-Peter Clausen
2013-05-23 13:06 ` [PATCH 2/2] regmap: Make regmap-mmio usable from different contexts Lars-Peter Clausen
2013-05-23 14:05 ` Mark Brown [this message]
2013-05-23 14:20 ` Lars-Peter Clausen
2013-05-23 14:31 ` Mark Brown
2013-05-23 14:36 ` Lars-Peter Clausen
2013-05-23 15:14 ` Mark Brown
2013-05-23 15:42 ` Stephen Warren
2013-05-23 15:50 ` Lars-Peter Clausen
2013-05-23 16:06 ` Stephen Warren
2013-05-23 16:10 ` Mark Brown
2013-05-23 16:01 ` Mark Brown
2013-05-23 14:08 ` [PATCH 1/2] regmap: regcache: Fixup locking for custom lock callbacks Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523140503.GD2412@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ciminaghi@gnudd.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox