From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Davide Ciminaghi <ciminaghi@gnudd.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] regmap: Make regmap-mmio usable from different contexts
Date: Thu, 23 May 2013 11:10:59 -0500 [thread overview]
Message-ID: <20130523161059.GC7660@sirena.org.uk> (raw)
In-Reply-To: <519E3AB7.8020103@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On Thu, May 23, 2013 at 05:50:15PM +0200, Lars-Peter Clausen wrote:
> On 05/23/2013 05:42 PM, Stephen Warren wrote:
> > I guess the core of the issue is that you want to replace spin_lock()
> > with spin_lock_irqsave(). I'd like to see that explicitly described in
> > the commit description, if that is the core aspect of this change.
> Hm, it does.
> regmap-mmio uses a spinlock with spin_lock() and spin_unlock() for
> locking.
> ...
> This patch updates the adds a flags parameter to the regmap lock
> and unlock callbacks and uses spin_lock_irqsave() and
> spin_unlock_restore() ...
That's pretty buried in the changelog though - really all the first
paragraph needs to say is that we want to use the irqsave versions to
allow interaction with interrupt context.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-05-23 16:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 13:06 [PATCH 1/2] regmap: regcache: Fixup locking for custom lock callbacks Lars-Peter Clausen
2013-05-23 13:06 ` [PATCH 2/2] regmap: Make regmap-mmio usable from different contexts Lars-Peter Clausen
2013-05-23 14:05 ` Mark Brown
2013-05-23 14:20 ` Lars-Peter Clausen
2013-05-23 14:31 ` Mark Brown
2013-05-23 14:36 ` Lars-Peter Clausen
2013-05-23 15:14 ` Mark Brown
2013-05-23 15:42 ` Stephen Warren
2013-05-23 15:50 ` Lars-Peter Clausen
2013-05-23 16:06 ` Stephen Warren
2013-05-23 16:10 ` Mark Brown [this message]
2013-05-23 16:01 ` Mark Brown
2013-05-23 14:08 ` [PATCH 1/2] regmap: regcache: Fixup locking for custom lock callbacks Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523161059.GC7660@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ciminaghi@gnudd.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox