Re: [PATCH 2/2] regmap: Make regmap-mmio usable from different contexts

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 936 bytes --]

On Thu, May 23, 2013 at 04:36:53PM +0200, Lars-Peter Clausen wrote:
> On 05/23/2013 04:31 PM, Mark Brown wrote:

> > So you'd have to allocate a struct on the stack with a pointer and the
> > flags in it and initialise the pointer.  Not awesome but not the end of
> > the world.

> I'm not sure I understand what you mean. This needs to be done for each
> caller of a lock()/unlock() pair. We can't allocate the flags on the stack
> inside the lock() function since the stack will be gone once the function exits.

Allocate the struct on the stack - if you can allocate flags on the
stack you can allocate the struct on the stack too.  Though I suppose
you still need to change all the callers for this which is just nasty
and makes it seem pointless to bother with abstraction here.

This is all stuff you should've been going through in the changelog when
you're jumping off into something that involves changing every single
user...

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]