public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: john.stultz@linaro.org, ohaugan@codeaurora.org,
	romlem@google.com, devel@driverdev.osuosl.org,
	konkers@android.com, linux-kernel@vger.kernel.org,
	ccross@android.com, rebecca@android.com, prtvar.b@gmail.com
Subject: Re: [PATCH] staging : android : fix checkpatch issues
Date: Sun, 9 Feb 2014 20:26:46 -0800	[thread overview]
Message-ID: <20140210042646.GA10320@kroah.com> (raw)
In-Reply-To: <2067517.LR5DRBeXLF@daeseok-laptop.cloud.net>

On Mon, Feb 10, 2014 at 10:59:14AM +0900, Daeseok Youn wrote:
> >From 1348300b03697d0499eddba6035a851d1278abd1 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <daeseok.youn@gmail.com>
> Date: Mon, 10 Feb 2014 10:45:30 +0900
> Subject: [PATCH] staging : android : fix checkpatch issues
> 
> drivers/staging/android/
> ion/ion.c :
>  - WARNNING: Unnecessary space after function pointer name
>  - ERROR: return is not a function, parentheses are not required
>  - WARNNING: Prefer seq_puts to seq_printf
>  - WARNING: quoted string split across lines
> 
> ion/ion_priv.h :
>  - WARNING: Unnecessary space after function pointer name
> 
> sync.h :
>  - WARNING: missing space after return type
> 
> timed_output.h :
>  - WARNING: Multiple spaces after return type

You are doing multiple things in different files, please break this up
into smaller patches...

thanks,

greg k-h

  reply	other threads:[~2014-02-10  4:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-10  1:59 [PATCH] staging : android : fix checkpatch issues Daeseok Youn
2014-02-10  4:26 ` Greg KH [this message]
2014-02-10  4:45   ` DaeSeok Youn
2014-02-10  9:11 ` Dan Carpenter
2014-02-10 10:23   ` DaeSeok Youn
2014-02-10 10:52     ` Dan Carpenter
2014-02-10 11:10       ` DaeSeok Youn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140210042646.GA10320@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ccross@android.com \
    --cc=daeseok.youn@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=john.stultz@linaro.org \
    --cc=konkers@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ohaugan@codeaurora.org \
    --cc=prtvar.b@gmail.com \
    --cc=rebecca@android.com \
    --cc=romlem@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox