From: Dan Carpenter <dan.carpenter@oracle.com>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: gregkh@linuxfoundation.org, john.stultz@linaro.org,
ohaugan@codeaurora.org, romlem@google.com,
devel@driverdev.osuosl.org, konkers@android.com,
linux-kernel@vger.kernel.org, ccross@android.com,
rebecca@android.com, prtvar.b@gmail.com
Subject: Re: [PATCH] staging : android : fix checkpatch issues
Date: Mon, 10 Feb 2014 12:11:35 +0300 [thread overview]
Message-ID: <20140210091135.GR26722@mwanda> (raw)
In-Reply-To: <2067517.LR5DRBeXLF@daeseok-laptop.cloud.net>
On Mon, Feb 10, 2014 at 10:59:14AM +0900, Daeseok Youn wrote:
> @@ -1376,14 +1376,14 @@ static int ion_debug_heap_show(struct seq_file *s, void *unused)
> }
> }
> mutex_unlock(&dev->buffer_lock);
> - seq_printf(s, "----------------------------------------------------\n");
> + seq_puts(s, "----------------------------------------------------\n");
> seq_printf(s, "%16.s %16zu\n", "total orphaned",
> total_orphaned_size);
This kind of thing where you put a seq_puts() in the middle of a string
of seq_printf() calls is not good. We only make checkpatch.pl warn
about it to see if patch submitters are paying attention and to test the
patience of reviewers.
regards,
dan carpenter
next prev parent reply other threads:[~2014-02-10 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 1:59 [PATCH] staging : android : fix checkpatch issues Daeseok Youn
2014-02-10 4:26 ` Greg KH
2014-02-10 4:45 ` DaeSeok Youn
2014-02-10 9:11 ` Dan Carpenter [this message]
2014-02-10 10:23 ` DaeSeok Youn
2014-02-10 10:52 ` Dan Carpenter
2014-02-10 11:10 ` DaeSeok Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210091135.GR26722@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ccross@android.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=konkers@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ohaugan@codeaurora.org \
--cc=prtvar.b@gmail.com \
--cc=rebecca@android.com \
--cc=romlem@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox