From: Dan Carpenter <dan.carpenter@oracle.com>
To: DaeSeok Youn <daeseok.youn@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
John Stultz <john.stultz@linaro.org>,
ohaugan@codeaurora.org, Rom Lemarchand <romlem@google.com>,
devel <devel@driverdev.osuosl.org>, konkers <konkers@android.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
ccross@android.com, Rebecca Zavin <rebecca@android.com>,
prtvar.b@gmail.com
Subject: Re: [PATCH] staging : android : fix checkpatch issues
Date: Mon, 10 Feb 2014 13:52:54 +0300 [thread overview]
Message-ID: <20140210105254.GB26776@mwanda> (raw)
In-Reply-To: <CAHb8M2AzdaFLyNkUhU8uTb_ztt3NoEW0QO8px1FRuHdK2cT4FA@mail.gmail.com>
On Mon, Feb 10, 2014 at 07:23:46PM +0900, DaeSeok Youn wrote:
> Thanks for reviewing.
>
> Yes, I just followed by reports of checkpatch.pl.
>
> But I don't understand why I can use of seq_puts() in the middle of
> seq_printf() calls.
> I have been trying to search why that is not good but I didn't find
> anything about that.
> And I saw patches which were already merged similar with this patch.
>
> You can see with this url
> https://github.com/torvalds/linux/commit/2d219c518882d2b2bac77742a6a8979c9dad051a
> https://github.com/mirrors/linux-2.6/commit/7aff38176e79a22b1749c2af74060028298e6a45
>
> If you don't mind, let me know why it is not good.
Because it doesn't look nice. It messes up the alignment.
Checkpatch is a tool not a king of the world. Stop obeying checkpatch.
regards,
dan carpenter
next prev parent reply other threads:[~2014-02-10 10:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 1:59 [PATCH] staging : android : fix checkpatch issues Daeseok Youn
2014-02-10 4:26 ` Greg KH
2014-02-10 4:45 ` DaeSeok Youn
2014-02-10 9:11 ` Dan Carpenter
2014-02-10 10:23 ` DaeSeok Youn
2014-02-10 10:52 ` Dan Carpenter [this message]
2014-02-10 11:10 ` DaeSeok Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210105254.GB26776@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ccross@android.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=konkers@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ohaugan@codeaurora.org \
--cc=prtvar.b@gmail.com \
--cc=rebecca@android.com \
--cc=romlem@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox