* [PATCH] staging: lustre: lov_pack: fix coding style issue
@ 2014-09-01 15:52 sunwxg
2014-09-01 16:26 ` Joe Perches
2014-09-02 17:31 ` Greg Kroah-Hartman
0 siblings, 2 replies; 3+ messages in thread
From: sunwxg @ 2014-09-01 15:52 UTC (permalink / raw)
To: Greg Kroah-Hartman, Dulshani Gunawardhana, Josh Triplett,
John L. Hammond, Andreas Dilger, Chi Pham, Oleg Drokin
Cc: Sun Wang, devel, linux-kernel
From: Sun Wang <sun.wxg@gmail.com>
Fix the style error checking by checkpatch.pl
ERROR: space required after that ','
Signed-off-by: Sun Wang <sun.wxg@gmail.com>
---
drivers/staging/lustre/lustre/lov/lov_pack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c b/drivers/staging/lustre/lustre/lov/lov_pack.c
index 20e5870..62ea223 100644
--- a/drivers/staging/lustre/lustre/lov/lov_pack.c
+++ b/drivers/staging/lustre/lustre/lov/lov_pack.c
@@ -95,7 +95,7 @@ void lov_dump_lmm_v1(int level, struct lov_mds_md_v1 *lmm)
void lov_dump_lmm_v3(int level, struct lov_mds_md_v3 *lmm)
{
lov_dump_lmm_common(level, lmm);
- CDEBUG(level,"pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);
+ CDEBUG(level, "pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);
lov_dump_lmm_objects(level, lmm->lmm_objects,
le16_to_cpu(lmm->lmm_stripe_count));
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: lustre: lov_pack: fix coding style issue
2014-09-01 15:52 [PATCH] staging: lustre: lov_pack: fix coding style issue sunwxg
@ 2014-09-01 16:26 ` Joe Perches
2014-09-02 17:31 ` Greg Kroah-Hartman
1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2014-09-01 16:26 UTC (permalink / raw)
To: sunwxg
Cc: Greg Kroah-Hartman, Dulshani Gunawardhana, Josh Triplett,
John L. Hammond, Andreas Dilger, Chi Pham, Oleg Drokin, devel,
linux-kernel
On Mon, 2014-09-01 at 23:52 +0800, sunwxg wrote:
> Fix the style error checking by checkpatch.pl
> ERROR: space required after that ','
[]
> diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c b/drivers/staging/lustre/lustre/lov/lov_pack.c
[]
> @@ -95,7 +95,7 @@ void lov_dump_lmm_v1(int level, struct lov_mds_md_v1 *lmm)
> void lov_dump_lmm_v3(int level, struct lov_mds_md_v3 *lmm)
> {
> lov_dump_lmm_common(level, lmm);
> - CDEBUG(level,"pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);
> + CDEBUG(level, "pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);
I think it better to separate the pre-coalesced
bits of the string like:
"pool name " LOV_POOLNAMEF "\n",
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: lustre: lov_pack: fix coding style issue
2014-09-01 15:52 [PATCH] staging: lustre: lov_pack: fix coding style issue sunwxg
2014-09-01 16:26 ` Joe Perches
@ 2014-09-02 17:31 ` Greg Kroah-Hartman
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2014-09-02 17:31 UTC (permalink / raw)
To: sunwxg
Cc: Dulshani Gunawardhana, Josh Triplett, John L. Hammond,
Andreas Dilger, Chi Pham, Oleg Drokin, devel, linux-kernel
On Mon, Sep 01, 2014 at 11:52:35PM +0800, sunwxg wrote:
> From: Sun Wang <sun.wxg@gmail.com>
>
> Fix the style error checking by checkpatch.pl
> ERROR: space required after that ','
>
> Signed-off-by: Sun Wang <sun.wxg@gmail.com>
>
> ---
> drivers/staging/lustre/lustre/lov/lov_pack.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Someone already submitted this fix before you did, sorry.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-02 17:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-01 15:52 [PATCH] staging: lustre: lov_pack: fix coding style issue sunwxg
2014-09-01 16:26 ` Joe Perches
2014-09-02 17:31 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox