* [PATCH] edac: remove dev_attr_sdram_scrub_rate on failure
@ 2015-02-03 1:54 Junjie Mao
2015-02-03 17:41 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: Junjie Mao @ 2015-02-03 1:54 UTC (permalink / raw)
To: Doug Thompson
Cc: Borislav Petkov, Mauro Carvalho Chehab, linux-edac, linux-kernel,
Junjie Mao
Signed-off-by: Junjie Mao <junjie.mao@hotmail.com>
---
drivers/edac/edac_mc_sysfs.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c
index 8e48d32efe37..ab2963bdd0d5 100644
--- a/drivers/edac/edac_mc_sysfs.c
+++ b/drivers/edac/edac_mc_sysfs.c
@@ -1068,6 +1068,8 @@ fail_unregister_dimm:
continue;
device_unregister(&dimm->dev);
}
+ if (mci->set_sdram_scrub_rate || mci->get_sdram_scrub_rate)
+ device_remove_file(&mci->dev, &dev_attr_sdram_scrub_rate);
fail_unregister_dev:
device_unregister(&mci->dev);
fail_unregister_bus:
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] edac: remove dev_attr_sdram_scrub_rate on failure
2015-02-03 1:54 [PATCH] edac: remove dev_attr_sdram_scrub_rate on failure Junjie Mao
@ 2015-02-03 17:41 ` Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2015-02-03 17:41 UTC (permalink / raw)
To: Junjie Mao; +Cc: Doug Thompson, Mauro Carvalho Chehab, linux-edac, linux-kernel
On Tue, Feb 03, 2015 at 09:54:41AM +0800, Junjie Mao wrote:
Commit message here please.
> Signed-off-by: Junjie Mao <junjie.mao@hotmail.com>
> ---
> drivers/edac/edac_mc_sysfs.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c
> index 8e48d32efe37..ab2963bdd0d5 100644
> --- a/drivers/edac/edac_mc_sysfs.c
> +++ b/drivers/edac/edac_mc_sysfs.c
> @@ -1068,6 +1068,8 @@ fail_unregister_dimm:
> continue;
> device_unregister(&dimm->dev);
> }
> + if (mci->set_sdram_scrub_rate || mci->get_sdram_scrub_rate)
> + device_remove_file(&mci->dev, &dev_attr_sdram_scrub_rate);
> fail_unregister_dev:
> device_unregister(&mci->dev);
> fail_unregister_bus:
Do I see it correctly that the destroy path
edac_remove_sysfs_mci_device() doesn't call device_remove_file() on that
sysfs node either?
Please add that code too.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-03 17:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-03 1:54 [PATCH] edac: remove dev_attr_sdram_scrub_rate on failure Junjie Mao
2015-02-03 17:41 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox