From: Lee Jones <lee.jones@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Sangbeom Kim <sbkim73@samsung.com>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] mfd: sec: Remove unnecessary out of memory message
Date: Thu, 26 Feb 2015 11:01:44 +0000 [thread overview]
Message-ID: <20150226110144.GN6688@x1> (raw)
In-Reply-To: <1424942031-28370-3-git-send-email-k.kozlowski@samsung.com>
On Thu, 26 Feb 2015, Krzysztof Kozlowski wrote:
> There is no need to print additional ENOMEM message for
> sec_platform_data allocation failure.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
> Changes since v1:
> 1. New patch.
> ---
> drivers/mfd/sec-core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
> index 423a2d3da4b2..2253d44e631c 100644
> --- a/drivers/mfd/sec-core.c
> +++ b/drivers/mfd/sec-core.c
> @@ -267,10 +267,8 @@ static struct sec_platform_data *sec_pmic_i2c_parse_dt_pdata(
> struct sec_platform_data *pd;
>
> pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL);
> - if (!pd) {
> - dev_err(dev, "could not allocate memory for pdata\n");
> + if (!pd)
> return ERR_PTR(-ENOMEM);
> - }
>
> /*
> * ToDo: the 'wakeup' member in the platform data is more of a linux
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-02-26 11:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 9:13 [PATCH v2 1/3] rtc: s5m: Remove unused watchdog and sudden momentary power loss Krzysztof Kozlowski
2015-02-26 9:13 ` [PATCH v2 2/3] mfd: sec: Cleanup unused RTC fields: ono, WTSR and SMPL Krzysztof Kozlowski
2015-02-26 11:01 ` Lee Jones
2015-02-26 9:13 ` [PATCH v2 3/3] mfd: sec: Remove unnecessary out of memory message Krzysztof Kozlowski
2015-02-26 11:01 ` Lee Jones [this message]
2015-02-26 10:47 ` [PATCH v2 1/3] rtc: s5m: Remove unused watchdog and sudden momentary power loss Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150226110144.GN6688@x1 \
--to=lee.jones@linaro.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox