* [PATCH] staging/lustre: Make lstcon_console_{init,fini} static
@ 2015-03-07 11:41 Peter Senna Tschudin
2015-03-07 13:13 ` Sudip Mukherjee
0 siblings, 1 reply; 2+ messages in thread
From: Peter Senna Tschudin @ 2015-03-07 11:41 UTC (permalink / raw)
To: Oleg Drokin, Andreas Dilger, Greg Kroah-Hartman, Luca Ceresoli,
Peter P Waskiewicz Jr, Heena Sirwani, Vitaly Osipov, Asaf Vertz,
Himangi Saraogi, Greg Donald, Joe Perches, HPDD-discuss, devel,
linux-kernel
Cc: Peter Senna Tschudin
sparse was complaining that the symbols 'lstcon_console_init'
and 'lstcon_console_fini' were not declared.
Declaring both as static.
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/staging/lustre/lnet/selftest/console.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/staging/lustre/lnet/selftest/console.c
index 1e0afc2..6d62c48 100644
--- a/drivers/staging/lustre/lnet/selftest/console.c
+++ b/drivers/staging/lustre/lnet/selftest/console.c
@@ -1989,8 +1989,7 @@ extern int lstcon_ioctl_entry(unsigned int cmd, struct libcfs_ioctl_data *data);
static DECLARE_IOCTL_HANDLER(lstcon_ioctl_handler, lstcon_ioctl_entry);
/* initialize console */
-int
-lstcon_console_init(void)
+static int lstcon_console_init(void)
{
int i;
int rc;
@@ -2059,8 +2058,7 @@ out:
return rc;
}
-int
-lstcon_console_fini(void)
+static int lstcon_console_fini(void)
{
int i;
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging/lustre: Make lstcon_console_{init,fini} static
2015-03-07 11:41 [PATCH] staging/lustre: Make lstcon_console_{init,fini} static Peter Senna Tschudin
@ 2015-03-07 13:13 ` Sudip Mukherjee
0 siblings, 0 replies; 2+ messages in thread
From: Sudip Mukherjee @ 2015-03-07 13:13 UTC (permalink / raw)
To: Peter Senna Tschudin
Cc: Oleg Drokin, Andreas Dilger, Greg Kroah-Hartman, Luca Ceresoli,
Peter P Waskiewicz Jr, Heena Sirwani, Vitaly Osipov, Asaf Vertz,
Himangi Saraogi, Greg Donald, Joe Perches, HPDD-discuss, devel,
linux-kernel
On Sat, Mar 07, 2015 at 12:41:06PM +0100, Peter Senna Tschudin wrote:
> sparse was complaining that the symbols 'lstcon_console_init'
> and 'lstcon_console_fini' were not declared.
>
> Declaring both as static.
you have not even build tested your patch.
WARNING: "lstcon_console_init" [drivers/staging/lustre/lnet/selftest/lnet_selftest.ko] undefined!
WARNING: "lstcon_console_fini" [drivers/staging/lustre/lnet/selftest/lnet_selftest.ko] undefined!
both of them are being used in selftest/module.c
regards
sudip
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> drivers/staging/lustre/lnet/selftest/console.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/staging/lustre/lnet/selftest/console.c
> index 1e0afc2..6d62c48 100644
> --- a/drivers/staging/lustre/lnet/selftest/console.c
> +++ b/drivers/staging/lustre/lnet/selftest/console.c
> @@ -1989,8 +1989,7 @@ extern int lstcon_ioctl_entry(unsigned int cmd, struct libcfs_ioctl_data *data);
> static DECLARE_IOCTL_HANDLER(lstcon_ioctl_handler, lstcon_ioctl_entry);
>
> /* initialize console */
> -int
> -lstcon_console_init(void)
> +static int lstcon_console_init(void)
> {
> int i;
> int rc;
> @@ -2059,8 +2058,7 @@ out:
> return rc;
> }
>
> -int
> -lstcon_console_fini(void)
> +static int lstcon_console_fini(void)
> {
> int i;
>
> --
> 2.1.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-07 13:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-07 11:41 [PATCH] staging/lustre: Make lstcon_console_{init,fini} static Peter Senna Tschudin
2015-03-07 13:13 ` Sudip Mukherjee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox