public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86: remove unused get_bios_ebda_length
@ 2015-03-19 10:55 Alexander Kuleshov
  2015-03-19 11:16 ` Borislav Petkov
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Kuleshov @ 2015-03-19 10:55 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin
  Cc: linux-kernel, Alexander Kuleshov

get_bios_ebda_length function from <asm/bios_ebda.h> was added
in the 57d5f9f808b7650a92f31e9cd3acd3f415a22530 commit, but
still not uses anywhere, let's remove it.

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
 arch/x86/include/asm/bios_ebda.h | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/arch/x86/include/asm/bios_ebda.h b/arch/x86/include/asm/bios_ebda.h
index aa6a317..2b00c77 100644
--- a/arch/x86/include/asm/bios_ebda.h
+++ b/arch/x86/include/asm/bios_ebda.h
@@ -17,27 +17,6 @@ static inline unsigned int get_bios_ebda(void)
 	return address;	/* 0 means none */
 }
 
-/*
- * Return the sanitized length of the EBDA in bytes, if it exists.
- */
-static inline unsigned int get_bios_ebda_length(void)
-{
-	unsigned int address;
-	unsigned int length;
-
-	address = get_bios_ebda();
-	if (!address)
-		return 0;
-
-	/* EBDA length is byte 0 of the EBDA (stored in KiB) */
-	length = *(unsigned char *)phys_to_virt(address);
-	length <<= 10;
-
-	/* Trim the length if it extends beyond 640KiB */
-	length = min_t(unsigned int, (640 * 1024) - address, length);
-	return length;
-}
-
 void reserve_ebda_region(void);
 
 #ifdef CONFIG_X86_CHECK_BIOS_CORRUPTION
-- 
2.3.3.472.g20ceeac.dirty


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] x86: remove unused get_bios_ebda_length
  2015-03-19 10:55 [PATCH] x86: remove unused get_bios_ebda_length Alexander Kuleshov
@ 2015-03-19 11:16 ` Borislav Petkov
  0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2015-03-19 11:16 UTC (permalink / raw)
  To: Alexander Kuleshov
  Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, linux-kernel,
	Mike Waychison, Greg KH

On Thu, Mar 19, 2015 at 04:55:37PM +0600, Alexander Kuleshov wrote:
> get_bios_ebda_length function from <asm/bios_ebda.h> was added
> in the 57d5f9f808b7650a92f31e9cd3acd3f415a22530 commit, but

You probably should've added the people involved in that commit to CC.
They might still need it, although I doubt it. :-)

> still not uses anywhere, let's remove it.
> 
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
>  arch/x86/include/asm/bios_ebda.h | 21 ---------------------
>  1 file changed, 21 deletions(-)
> 
> diff --git a/arch/x86/include/asm/bios_ebda.h b/arch/x86/include/asm/bios_ebda.h
> index aa6a317..2b00c77 100644
> --- a/arch/x86/include/asm/bios_ebda.h
> +++ b/arch/x86/include/asm/bios_ebda.h
> @@ -17,27 +17,6 @@ static inline unsigned int get_bios_ebda(void)
>  	return address;	/* 0 means none */
>  }
>  
> -/*
> - * Return the sanitized length of the EBDA in bytes, if it exists.
> - */
> -static inline unsigned int get_bios_ebda_length(void)
> -{
> -	unsigned int address;
> -	unsigned int length;
> -
> -	address = get_bios_ebda();
> -	if (!address)
> -		return 0;
> -
> -	/* EBDA length is byte 0 of the EBDA (stored in KiB) */
> -	length = *(unsigned char *)phys_to_virt(address);
> -	length <<= 10;
> -
> -	/* Trim the length if it extends beyond 640KiB */
> -	length = min_t(unsigned int, (640 * 1024) - address, length);
> -	return length;
> -}
> -
>  void reserve_ebda_region(void);
>  
>  #ifdef CONFIG_X86_CHECK_BIOS_CORRUPTION
> -- 
> 2.3.3.472.g20ceeac.dirty
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-19 11:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-19 10:55 [PATCH] x86: remove unused get_bios_ebda_length Alexander Kuleshov
2015-03-19 11:16 ` Borislav Petkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox