From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Douglas Figueiredo <eng.douglasfigueiredo@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
vitaly.osipov@gmail.com, matt@ninezulu.com,
tapaswenipathak@gmail.com, artemiyv@acm.org,
raghav3276@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] [930672e8693a] Task 10 of the Eudyptula Challenge
Date: Tue, 19 May 2015 10:33:26 +0530 [thread overview]
Message-ID: <20150519050326.GB3820@sudip-PC> (raw)
In-Reply-To: <1432011010-10358-1-git-send-email-eng.douglasfigueiredo@gmail.com>
On Tue, May 19, 2015 at 01:50:10AM -0300, Douglas Figueiredo wrote:
> From: douglasbsf <eng.douglasfigueiredo@gmail.com>
>
> Fixed Coding Style Problem in drivers/staging/wlan-ng/prism2fw.c
1) mention which coding style problem you fixed in the commit message.
2) no need to mention the challenge in the subject, the subject can be
something like [PATCH] staging: wlan-ng: fix long line
3) when you are sending a single patch, no need to mention 1/1
and what is that 930672e8693a? my guess its your commit id in your local
git. No need to mention that also.
regards
sudip
next prev parent reply other threads:[~2015-05-19 5:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 4:50 [PATCH 1/1] [930672e8693a] Task 10 of the Eudyptula Challenge Douglas Figueiredo
2015-05-19 5:03 ` Sudip Mukherjee [this message]
2015-05-19 5:09 ` Douglas Figueiredo
2015-05-19 14:17 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519050326.GB3820@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=artemiyv@acm.org \
--cc=devel@driverdev.osuosl.org \
--cc=eng.douglasfigueiredo@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@ninezulu.com \
--cc=raghav3276@gmail.com \
--cc=tapaswenipathak@gmail.com \
--cc=vitaly.osipov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox