The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Douglas Figueiredo <eng.douglasfigueiredo@gmail.com>
Cc: raghav3276@gmail.com, devel@driverdev.osuosl.org,
	artemiyv@acm.org, tapaswenipathak@gmail.com, matt@ninezulu.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] [930672e8693a] Task 10 of the Eudyptula Challenge
Date: Tue, 19 May 2015 07:17:27 -0700	[thread overview]
Message-ID: <20150519141727.GA6578@kroah.com> (raw)
In-Reply-To: <1432011010-10358-1-git-send-email-eng.douglasfigueiredo@gmail.com>

On Tue, May 19, 2015 at 01:50:10AM -0300, Douglas Figueiredo wrote:
> From: douglasbsf <eng.douglasfigueiredo@gmail.com>

We need a "real" name here, and in the signed-off-by line.

Also fix up your subject line like mentioned.

> 
> Fixed Coding Style Problem in drivers/staging/wlan-ng/prism2fw.c
> 
> Signed-off-by: douglasbsf <eng.douglasfigueiredo@gmail.com>
> ---
>  drivers/staging/wlan-ng/prism2fw.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
> index 9408644..27ead4c 100644
> --- a/drivers/staging/wlan-ng/prism2fw.c
> +++ b/drivers/staging/wlan-ng/prism2fw.c
> @@ -708,7 +708,9 @@ static int plugimage(struct imgchunk *fchunk, unsigned int nfchunks,
>  			continue;
>  		}
>  
> -		/* Validate plug address against chunk data and identify chunk */
> +		/* Validate plug address against
> +		* chunk data and identify chunk
> +		*/

Please use the correct indentation for multi-line comments as well.

Please fix up and resend, I can't take this as-is.

greg k-h

      parent reply	other threads:[~2015-05-19 14:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-19  4:50 [PATCH 1/1] [930672e8693a] Task 10 of the Eudyptula Challenge Douglas Figueiredo
2015-05-19  5:03 ` Sudip Mukherjee
2015-05-19  5:09   ` Douglas Figueiredo
2015-05-19 14:17 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150519141727.GA6578@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=artemiyv@acm.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=eng.douglasfigueiredo@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@ninezulu.com \
    --cc=raghav3276@gmail.com \
    --cc=tapaswenipathak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox