[PATCH 1/1] [930672e8693a] Task 10 of the Eudyptula Challenge

[PATCH 1/1] [930672e8693a] Task 10 of the Eudyptula Challenge

[Douglas Figueiredo]

From: douglasbsf <eng.douglasfigueiredo@gmail.com>

Fixed Coding Style Problem in drivers/staging/wlan-ng/prism2fw.c

Signed-off-by: douglasbsf <eng.douglasfigueiredo@gmail.com>
---
 drivers/staging/wlan-ng/prism2fw.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
index 9408644..27ead4c 100644
--- a/drivers/staging/wlan-ng/prism2fw.c
+++ b/drivers/staging/wlan-ng/prism2fw.c
@@ -708,7 +708,9 @@ static int plugimage(struct imgchunk *fchunk, unsigned int nfchunks,
 			continue;
 		}
 
-		/* Validate plug address against chunk data and identify chunk */
+		/* Validate plug address against
+		* chunk data and identify chunk
+		*/
 		for (c = 0; c < nfchunks; c++) {
 			cstart = fchunk[c].addr;
 			cend = fchunk[c].addr + fchunk[c].len;
@@ -923,7 +925,8 @@ static int read_fwfile(const struct ihex_binrec *record)
 				      rcnt,
 				      s3info[ns3info].len,
 				      s3info[ns3info].type);
-			if (((s3info[ns3info].len - 1) * sizeof(u16)) > sizeof(s3info[ns3info].info)) {
+			if (((s3info[ns3info].len - 1) * sizeof(u16)) >
+				sizeof(s3info[ns3info].info)) {
 				pr_err("S3 inforec length too long - aborting\n");
 				return 1;
 			}
-- 
1.9.3

Re: [PATCH 1/1] [930672e8693a] Task 10 of the Eudyptula Challenge

[Sudip Mukherjee]

On Tue, May 19, 2015 at 01:50:10AM -0300, Douglas Figueiredo wrote:
> From: douglasbsf <eng.douglasfigueiredo@gmail.com>
> 
> Fixed Coding Style Problem in drivers/staging/wlan-ng/prism2fw.c

1) mention which coding style problem you fixed in the commit message.
2) no need to mention the challenge in the subject, the subject can be
something like [PATCH] staging: wlan-ng: fix long line
3) when you are sending a single patch, no need to mention 1/1

and what is that 930672e8693a? my guess its your commit id in your local
git. No need to mention that also.

regards
sudip

Re: [PATCH 1/1] [930672e8693a] Task 10 of the Eudyptula Challenge

[Douglas Figueiredo]

thanks for yours hints.

930672e8693a is my ID on the challenge, I will take care about this
things in the future.

2015-05-19 2:03 GMT-03:00 Sudip Mukherjee <sudipm.mukherjee@gmail.com>:
> On Tue, May 19, 2015 at 01:50:10AM -0300, Douglas Figueiredo wrote:
>> From: douglasbsf <eng.douglasfigueiredo@gmail.com>
>>
>> Fixed Coding Style Problem in drivers/staging/wlan-ng/prism2fw.c
>
> 1) mention which coding style problem you fixed in the commit message.
> 2) no need to mention the challenge in the subject, the subject can be
> something like [PATCH] staging: wlan-ng: fix long line
> 3) when you are sending a single patch, no need to mention 1/1
>
> and what is that 930672e8693a? my guess its your commit id in your local
> git. No need to mention that also.
>
> regards
> sudip

Re: [PATCH 1/1] [930672e8693a] Task 10 of the Eudyptula Challenge

[Greg Kroah-Hartman]

On Tue, May 19, 2015 at 01:50:10AM -0300, Douglas Figueiredo wrote:
> From: douglasbsf <eng.douglasfigueiredo@gmail.com>

We need a "real" name here, and in the signed-off-by line.

Also fix up your subject line like mentioned.

> 
> Fixed Coding Style Problem in drivers/staging/wlan-ng/prism2fw.c
> 
> Signed-off-by: douglasbsf <eng.douglasfigueiredo@gmail.com>
> ---
>  drivers/staging/wlan-ng/prism2fw.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
> index 9408644..27ead4c 100644
> --- a/drivers/staging/wlan-ng/prism2fw.c
> +++ b/drivers/staging/wlan-ng/prism2fw.c
> @@ -708,7 +708,9 @@ static int plugimage(struct imgchunk *fchunk, unsigned int nfchunks,
>  			continue;
>  		}
>  
> -		/* Validate plug address against chunk data and identify chunk */
> +		/* Validate plug address against
> +		* chunk data and identify chunk
> +		*/

Please use the correct indentation for multi-line comments as well.

Please fix up and resend, I can't take this as-is.

greg k-h