From: Jean Delvare <jdelvare@suse.de>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 WIP 1/5] parport: add device-model to parport subsystem
Date: Wed, 20 May 2015 09:54:37 +0200 [thread overview]
Message-ID: <20150520095437.5966713b@endymion.delvare> (raw)
In-Reply-To: <1430907377-17147-1-git-send-email-sudipm.mukherjee@gmail.com>
On Wed, 6 May 2015 15:46:13 +0530, Sudip Mukherjee wrote:
> parport subsystem starts using the device-model. drivers using the
> device-model has to define probe and should register the device with
> parport with parport_register_dev_model()
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
Just one think I noticed while reviewing the i2c-parport patches:
> +struct pardevice *
> +parport_register_dev_model(struct parport *port, const char *name,
> + struct pardev_cb *par_dev_cb, int cnt)
par_dev_cb isn't modified by this function so it should be const.
Also I don't much like the name "cnt", as the value is not a count,
it's an index or identifier. What about "id"?
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2015-05-20 7:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 10:16 [PATCH v5 WIP 1/5] parport: add device-model to parport subsystem Sudip Mukherjee
2015-05-06 10:16 ` [PATCH v5 WIP 2/5] staging: panel: use new parport device model Sudip Mukherjee
2015-05-19 11:18 ` Dan Carpenter
2015-05-20 8:23 ` Jean Delvare
2015-05-06 10:16 ` [PATCH v5 WIP 3/5] i2c-parport: define ports to connect Sudip Mukherjee
2015-05-19 7:50 ` Jean Delvare
2015-05-19 8:44 ` Sudip Mukherjee
2015-05-19 9:28 ` Jean Delvare
2015-05-19 9:58 ` Sudip Mukherjee
2015-05-19 11:23 ` Dan Carpenter
2015-05-19 12:23 ` Jean Delvare
2015-05-06 10:16 ` [PATCH v5 WIP 4/5] i2c-parport: use new parport device model Sudip Mukherjee
2015-05-20 7:57 ` Jean Delvare
2015-05-20 8:16 ` Sudip Mukherjee
2015-05-06 10:16 ` [PATCH v5 WIP 5/5] paride: " Sudip Mukherjee
2015-05-19 11:32 ` Dan Carpenter
2015-05-19 12:32 ` Sudip Mukherjee
2015-05-20 8:07 ` Jean Delvare
2015-05-20 8:33 ` Sudip Mukherjee
2015-05-19 11:08 ` [PATCH v5 WIP 1/5] parport: add device-model to parport subsystem Dan Carpenter
2015-05-19 13:18 ` Sudip Mukherjee
2015-05-20 7:54 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520095437.5966713b@endymion.delvare \
--to=jdelvare@suse.de \
--cc=dan.carpenter@oracle.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox