* [PATCH] EDAC, mce_amd_inj: Include irq_vectors header to fix build errors
@ 2015-06-05 23:07 Aravind Gopalakrishnan
2015-06-06 7:50 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: Aravind Gopalakrishnan @ 2015-06-05 23:07 UTC (permalink / raw)
To: dougthompson, bp, mchehab
Cc: linux-edac, linux-kernel, fengguang.wu, kbuild-all
Even though !CONFIG_SMP and MCE injection are practically mutually
exclusive, it's better to include irq_vectors.h just in case
randconfig builders out there don't set CONFIG_SMP.
When that happens, DEFERRED_ERROR_VECTOR and THRESHOLD_APIC_VECTOR
macro definitions go out of scope and kernel build will fail.
Tested the .config that broke the build against latest tip with
changes in for-next branch of bp.git and it builds fine now.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Cc: kbuild-all@01.org
Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
---
drivers/edac/mce_amd_inj.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/edac/mce_amd_inj.c b/drivers/edac/mce_amd_inj.c
index 3f7217f..3e1b53f 100644
--- a/drivers/edac/mce_amd_inj.c
+++ b/drivers/edac/mce_amd_inj.c
@@ -18,6 +18,7 @@
#include <linux/string.h>
#include <linux/uaccess.h>
#include <asm/mce.h>
+#include <asm/irq_vectors.h>
#include "mce_amd.h"
--
2.4.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] EDAC, mce_amd_inj: Include irq_vectors header to fix build errors
2015-06-05 23:07 [PATCH] EDAC, mce_amd_inj: Include irq_vectors header to fix build errors Aravind Gopalakrishnan
@ 2015-06-06 7:50 ` Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2015-06-06 7:50 UTC (permalink / raw)
To: Aravind Gopalakrishnan
Cc: dougthompson, mchehab, linux-edac, linux-kernel, fengguang.wu,
kbuild-all
On Fri, Jun 05, 2015 at 06:07:34PM -0500, Aravind Gopalakrishnan wrote:
> Even though !CONFIG_SMP and MCE injection are practically mutually
> exclusive, it's better to include irq_vectors.h just in case
> randconfig builders out there don't set CONFIG_SMP.
>
> When that happens, DEFERRED_ERROR_VECTOR and THRESHOLD_APIC_VECTOR
> macro definitions go out of scope and kernel build will fail.
Good!
> Tested the .config that broke the build against latest tip with
> changes in for-next branch of bp.git and it builds fine now.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Cc: kbuild-all@01.org
> Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
> ---
> drivers/edac/mce_amd_inj.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/edac/mce_amd_inj.c b/drivers/edac/mce_amd_inj.c
> index 3f7217f..3e1b53f 100644
> --- a/drivers/edac/mce_amd_inj.c
> +++ b/drivers/edac/mce_amd_inj.c
> @@ -18,6 +18,7 @@
> #include <linux/string.h>
> #include <linux/uaccess.h>
> #include <asm/mce.h>
> +#include <asm/irq_vectors.h>
>
> #include "mce_amd.h"
Applied, thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-06 7:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-05 23:07 [PATCH] EDAC, mce_amd_inj: Include irq_vectors header to fix build errors Aravind Gopalakrishnan
2015-06-06 7:50 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox