[EDT][PATCH] XHCI: Fix memory leak in error condition

[EDT][PATCH] XHCI: Fix memory leak in error condition

[Vivek Kumar Bhagat]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 759 bytes --]

EP-EC562D6B53594479BCA6FC73F17DEE54
In error condition, td buffer is not freed which can lead
to memory leak.

Signed-off-by: Vivek Kumar Bhagat <vivek.bhagat@samsung.com>
---
 drivers/usb/host/xhci.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 36bf089..dc02532 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -1438,6 +1438,7 @@ dying:
 	ret = -ESHUTDOWN;
 free_priv:
 	xhci_urb_free_priv(urb_priv);
+	kfree(buffer);
 	urb->hcpriv = NULL;
 	spin_unlock_irqrestore(&xhci->lock, flags);
 	return ret;
-- 
1.7.9.5ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [EDT][PATCH] XHCI: Fix memory leak in error condition

[Roger Quadros]

On 26/06/15 10:46, Vivek Kumar Bhagat wrote:
> EP-EC562D6B53594479BCA6FC73F17DEE54
> In error condition, td buffer is not freed which can lead
> to memory leak.
>
> Signed-off-by: Vivek Kumar Bhagat <vivek.bhagat@samsung.com>
> ---
>   drivers/usb/host/xhci.c |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 36bf089..dc02532 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -1438,6 +1438,7 @@ dying:
>   	ret = -ESHUTDOWN;
>   free_priv:
>   	xhci_urb_free_priv(urb_priv);
> +	kfree(buffer);
>   	urb->hcpriv = NULL;
>   	spin_unlock_irqrestore(&xhci->lock, flags);
>   	return ret;
>

Do you need to fix up xhci_urb_free_priv() as well?

cheers,
-roger

Re: [EDT][PATCH] XHCI: Fix memory leak in error condition

[Greg KH]

On Fri, Jun 26, 2015 at 07:46:00AM +0000, Vivek Kumar Bhagat wrote:
> EP-EC562D6B53594479BCA6FC73F17DEE54

What is that crazy line for?  It doesn't belong here.

Re: [EDT][PATCH] XHCI: Fix memory leak in error condition

[Greg KH]

On Fri, Jun 26, 2015 at 07:46:00AM +0000, Vivek Kumar Bhagat wrote:
> EP-EC562D6B53594479BCA6FC73F17DEE54
> In error condition, td buffer is not freed which can lead
> to memory leak.
> 
> Signed-off-by: Vivek Kumar Bhagat <vivek.bhagat@samsung.com>
> ---
>  drivers/usb/host/xhci.c |    1 +
>  1 file changed, 1 insertion(+)

Also, please use scripts/get_maintainer.pl to determine who to send
patches to.  Hint, I'm not the one for this patch, I can't do anything
with it...