[PATCH] Checkpatch: driver/staging in 4.2.0-rc4: Fix coding style problem

[PATCH] Checkpatch: driver/staging in 4.2.0-rc4: Fix coding style problem

[Jignesh R Patel]

From: Jignesh R Patel <jigneshpatel0103@gmail.com>

This patch fix coding style problem of more then
80 character in one line. This patch does not change any
logic.

Signed-off-by: Jignesh R Patel <jigneshpatel0103@gmail.com>
---
 drivers/staging/android/ion/ion_cma_heap.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
index 86b91fd..4a9a7bd 100644
--- a/drivers/staging/android/ion/ion_cma_heap.c
+++ b/drivers/staging/android/ion/ion_cma_heap.c
@@ -73,7 +73,8 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
 	if (!info->table)
 		goto free_mem;
 
-	if (dma_get_sgtable(dev, info->table, info->cpu_addr, info->handle, len))
+	if (dma_get_sgtable(dev, info->table, info->cpu_addr,
+						info->handle, len))
 		goto free_table;
 	/* keep this for memory release */
 	buffer->priv_virt = info;
-- 
1.7.9.5

Re: [PATCH] Checkpatch: driver/staging in 4.2.0-rc4: Fix coding style problem

[Dan Carpenter]

The subject isn't right.  You aren't patch checkpatch.pl itself you're
patching android.

The version doesn't go in the subject.

The subject is too vague.

On Tue, Jul 28, 2015 at 03:28:33PM +0530, Jignesh R Patel wrote:
> From: Jignesh R Patel <jigneshpatel0103@gmail.com>

Not needed.

> 
> This patch fix coding style problem of more then
> 80 character in one line. This patch does not change any
> logic.
> 
> Signed-off-by: Jignesh R Patel <jigneshpatel0103@gmail.com>
> ---
>  drivers/staging/android/ion/ion_cma_heap.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
> index 86b91fd..4a9a7bd 100644
> --- a/drivers/staging/android/ion/ion_cma_heap.c
> +++ b/drivers/staging/android/ion/ion_cma_heap.c
> @@ -73,7 +73,8 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
>  	if (!info->table)
>  		goto free_mem;
>  
> -	if (dma_get_sgtable(dev, info->table, info->cpu_addr, info->handle, len))
> +	if (dma_get_sgtable(dev, info->table, info->cpu_addr,
> +						info->handle, len))

This isn't the right way to do it.  I suppose the right thing is:

	if (dma_get_sgtable(dev, info->table, info->cpu_addr, info->handle,
			    len))

regards,
dan carpenter