From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rafael Wysocki <rjw@rjwysocki.net>
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
alexandra.yates@linux.intel.com,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: cpufreq_cpu_get_raw() isn't a static function anymore
Date: Tue, 15 Sep 2015 13:44:45 +0530 [thread overview]
Message-ID: <20150915081445.GD6350@linux> (raw)
In-Reply-To: <d7e3e729d09d15cfc73ebaf251a2bb4d33ec54a9.1442303903.git.viresh.kumar@linaro.org>
On 15-09-15, 13:40, Viresh Kumar wrote:
> Its used outside of the core file and is exported as well. Drop the
> 'static' keyword from its declaration and fix below build error:
>
> linux/drivers/cpufreq/cpufreq.c:241:31: error: static declaration of
> 'cpufreq_cpu_get_raw' follows non-static declaration
>
> Fixes: 503655f70d9b ("cpufreq: acpi-cpufreq: Use cpufreq_cpu_get_raw() in ->get()")
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/cpufreq/cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Urg, sorry for spamming wrong people (Thomas/Alexandra) for an
unrelated patch.
Have sent the relevant patch with this subject now:
"PM / sleep: Fix broken builds without CONFIG_PM_SLEEP_DEBUG"
Though, this fix was also relevant, just sent it to wrong people :(
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index a8252bb0f80c..ef5ed9470de9 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -238,7 +238,7 @@ int cpufreq_generic_init(struct cpufreq_policy *policy,
> }
> EXPORT_SYMBOL_GPL(cpufreq_generic_init);
>
> -static struct cpufreq_policy *cpufreq_cpu_get_raw(unsigned int cpu)
> +struct cpufreq_policy *cpufreq_cpu_get_raw(unsigned int cpu)
> {
> struct cpufreq_policy *policy = per_cpu(cpufreq_cpu_data, cpu);
>
> --
> 2.4.0
>
--
viresh
prev parent reply other threads:[~2015-09-15 8:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 8:10 [PATCH] cpufreq: cpufreq_cpu_get_raw() isn't a static function anymore Viresh Kumar
2015-09-15 8:14 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150915081445.GD6350@linux \
--to=viresh.kumar@linaro.org \
--cc=alexandra.yates@linux.intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox