* [PATCH] platform: x86: PMC IPC depends on ACPI
@ 2015-09-25 16:38 Lee Jones
2015-09-26 1:53 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Lee Jones @ 2015-09-25 16:38 UTC (permalink / raw)
To: linux-kernel; +Cc: rdunlap, qipeng.zha, dvhart, platform-driver-x86, Lee Jones
This patch solves:
on x86_64:
when CONFIG_ACPI is not enabled:
../drivers/mfd/intel_soc_pmic_bxtwc.c: In function 'bxtwc_probe':
../drivers/mfd/intel_soc_pmic_bxtwc.c:342:2:
error: implicit declaration of function 'acpi_evaluate_integer' [-Werror=implicit-function-declaration]
status = acpi_evaluate_integer(handle, "_HRV", NULL, &hrv);
^
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index c69bb70..744cb80 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -914,6 +914,7 @@ config PVPANIC
config INTEL_PMC_IPC
tristate "Intel PMC IPC Driver"
+ depends on ACPI
---help---
This driver provides support for PMC control on some Intel platforms.
The PMC is an ARC processor which defines IPC commands for communication
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] platform: x86: PMC IPC depends on ACPI
2015-09-25 16:38 [PATCH] platform: x86: PMC IPC depends on ACPI Lee Jones
@ 2015-09-26 1:53 ` Randy Dunlap
2015-10-03 16:57 ` Darren Hart
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2015-09-26 1:53 UTC (permalink / raw)
To: Lee Jones, linux-kernel; +Cc: qipeng.zha, dvhart, platform-driver-x86
On 09/25/15 09:38, Lee Jones wrote:
> This patch solves:
>
> on x86_64:
>
> when CONFIG_ACPI is not enabled:
>
> ../drivers/mfd/intel_soc_pmic_bxtwc.c: In function 'bxtwc_probe':
> ../drivers/mfd/intel_soc_pmic_bxtwc.c:342:2:
> error: implicit declaration of function 'acpi_evaluate_integer' [-Werror=implicit-function-declaration]
> status = acpi_evaluate_integer(handle, "_HRV", NULL, &hrv);
> ^
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Works for me. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index c69bb70..744cb80 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -914,6 +914,7 @@ config PVPANIC
>
> config INTEL_PMC_IPC
> tristate "Intel PMC IPC Driver"
> + depends on ACPI
> ---help---
> This driver provides support for PMC control on some Intel platforms.
> The PMC is an ARC processor which defines IPC commands for communication
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] platform: x86: PMC IPC depends on ACPI
2015-09-26 1:53 ` Randy Dunlap
@ 2015-10-03 16:57 ` Darren Hart
0 siblings, 0 replies; 3+ messages in thread
From: Darren Hart @ 2015-10-03 16:57 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Lee Jones, linux-kernel, qipeng.zha, platform-driver-x86
On Fri, Sep 25, 2015 at 06:53:56PM -0700, Randy Dunlap wrote:
> On 09/25/15 09:38, Lee Jones wrote:
> > This patch solves:
> >
> > on x86_64:
> >
> > when CONFIG_ACPI is not enabled:
> >
> > ../drivers/mfd/intel_soc_pmic_bxtwc.c: In function 'bxtwc_probe':
> > ../drivers/mfd/intel_soc_pmic_bxtwc.c:342:2:
> > error: implicit declaration of function 'acpi_evaluate_integer' [-Werror=implicit-function-declaration]
> > status = acpi_evaluate_integer(handle, "_HRV", NULL, &hrv);
> > ^
> >
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> Works for me. Thanks.
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
Lee,
Since this appears to be the result of a patch applied to the mfd tree, would
you like to pick up this patch?
Acked-by: Darren Hart <dvhart@linux.intel.com>
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-03 16:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-25 16:38 [PATCH] platform: x86: PMC IPC depends on ACPI Lee Jones
2015-09-26 1:53 ` Randy Dunlap
2015-10-03 16:57 ` Darren Hart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox