* [PATCH] EDAC, altera: SoCFPGA EDAC should not look for ECC_CORR_EN
@ 2015-10-14 23:14 dinguyen
2015-10-15 9:57 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: dinguyen @ 2015-10-14 23:14 UTC (permalink / raw)
To: tthayer
Cc: dinh.linux, dougthompson, bp, mchehab, linux-edac, linux-kernel,
Dinh Nguyen
From: Dinh Nguyen <dinguyen@opensource.altera.com>
The bootloader may or may not enable the ECC_CORR_EN bit. By not enabling
ECC_CORR_EN, when error happens, it is the user's responsibility to perform
a full SDRAM scrub.
Remove the check for ECC_CORR_EN.
Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
---
drivers/edac/altera_edac.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/edac/altera_edac.h b/drivers/edac/altera_edac.h
index 7b64dc7..7a52585 100644
--- a/drivers/edac/altera_edac.h
+++ b/drivers/edac/altera_edac.h
@@ -30,8 +30,7 @@
#define CV_CTLCFG_GEN_SB_ERR 0x2000
#define CV_CTLCFG_GEN_DB_ERR 0x4000
-#define CV_CTLCFG_ECC_AUTO_EN (CV_CTLCFG_ECC_EN | \
- CV_CTLCFG_ECC_CORR_EN)
+#define CV_CTLCFG_ECC_AUTO_EN (CV_CTLCFG_ECC_EN)
/* SDRAM Controller Address Width Register */
#define CV_DRAMADDRW_OFST 0x2C
--
2.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] EDAC, altera: SoCFPGA EDAC should not look for ECC_CORR_EN
2015-10-14 23:14 [PATCH] EDAC, altera: SoCFPGA EDAC should not look for ECC_CORR_EN dinguyen
@ 2015-10-15 9:57 ` Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2015-10-15 9:57 UTC (permalink / raw)
To: dinguyen
Cc: tthayer, dinh.linux, dougthompson, mchehab, linux-edac,
linux-kernel
On Wed, Oct 14, 2015 at 06:14:16PM -0500, dinguyen@opensource.altera.com wrote:
> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>
> The bootloader may or may not enable the ECC_CORR_EN bit. By not enabling
> ECC_CORR_EN, when error happens, it is the user's responsibility to perform
> a full SDRAM scrub.
>
> Remove the check for ECC_CORR_EN.
>
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> ---
> drivers/edac/altera_edac.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/edac/altera_edac.h b/drivers/edac/altera_edac.h
> index 7b64dc7..7a52585 100644
> --- a/drivers/edac/altera_edac.h
> +++ b/drivers/edac/altera_edac.h
> @@ -30,8 +30,7 @@
> #define CV_CTLCFG_GEN_SB_ERR 0x2000
> #define CV_CTLCFG_GEN_DB_ERR 0x4000
>
> -#define CV_CTLCFG_ECC_AUTO_EN (CV_CTLCFG_ECC_EN | \
> - CV_CTLCFG_ECC_CORR_EN)
> +#define CV_CTLCFG_ECC_AUTO_EN (CV_CTLCFG_ECC_EN)
>
> /* SDRAM Controller Address Width Register */
> #define CV_DRAMADDRW_OFST 0x2C
> --
Applied,
thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-15 9:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-14 23:14 [PATCH] EDAC, altera: SoCFPGA EDAC should not look for ECC_CORR_EN dinguyen
2015-10-15 9:57 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox