[RFC] fpga: socfpga: Fix check of return value of devm_request_irq

[RFC] fpga: socfpga: Fix check of return value of devm_request_irq

[Moritz Fischer]

The return value should be checked for non-zero, instead
of checking it being IS_ERR_VALUE().

Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
---
 drivers/fpga/socfpga.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c
index 706b80d..27d2ff2 100644
--- a/drivers/fpga/socfpga.c
+++ b/drivers/fpga/socfpga.c
@@ -577,7 +577,7 @@ static int socfpga_fpga_probe(struct platform_device *pdev)
 
 	ret = devm_request_irq(dev, priv->irq, socfpga_fpga_isr, 0,
 			       dev_name(dev), priv);
-	if (IS_ERR_VALUE(ret))
+	if (ret)
 		return ret;
 
 	return fpga_mgr_register(dev, "Altera SOCFPGA FPGA Manager",
-- 
2.4.3

Re: [RFC] fpga: socfpga: Fix check of return value of devm_request_irq

[atull]

On Thu, 22 Oct 2015, Moritz Fischer wrote:

Hi Moritz,

Thank you, yes this is better.

I don't know if I need to ack everything, but here it is
anyway:

Acked-by: Alan Tull <atull@opensource.altera.com>

Alan

> The return value should be checked for non-zero, instead
> of checking it being IS_ERR_VALUE().
> 
> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
> ---
>  drivers/fpga/socfpga.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c
> index 706b80d..27d2ff2 100644
> --- a/drivers/fpga/socfpga.c
> +++ b/drivers/fpga/socfpga.c
> @@ -577,7 +577,7 @@ static int socfpga_fpga_probe(struct platform_device *pdev)
>  
>  	ret = devm_request_irq(dev, priv->irq, socfpga_fpga_isr, 0,
>  			       dev_name(dev), priv);
> -	if (IS_ERR_VALUE(ret))
> +	if (ret)
>  		return ret;
>  
>  	return fpga_mgr_register(dev, "Altera SOCFPGA FPGA Manager",
> -- 
> 2.4.3
> 
> 

Re: [RFC] fpga: socfpga: Fix check of return value of devm_request_irq

[Josh Cartwright]

[-- Attachment #1: Type: text/plain, Size: 1687 bytes --]


On Thu, Oct 22, 2015 at 02:24:03PM -0500, atull wrote:
> > The return value should be checked for non-zero, instead
> > of checking it being IS_ERR_VALUE().
> > 
> > Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
> On Thu, 22 Oct 2015, Moritz Fischer wrote:
> 
> Hi Moritz,
> 
> Thank you, yes this is better.
> 
> I don't know if I need to ack everything, but here it is
> anyway:
> 
> Acked-by: Alan Tull <atull@opensource.altera.com>

Because Greg is the one picking up patches for the FPGA manager stuff
right now, you'll want to make sure he's at least CC'd.  A proper resend
would likely be the easiest way for him to pick it up.

Feel free to add by Reviewed-by as well:

Reviewed-by: Josh Cartwright <joshc@eso.teric.us>

Thanks,
  Josh

> > ---
> >  drivers/fpga/socfpga.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c
> > index 706b80d..27d2ff2 100644
> > --- a/drivers/fpga/socfpga.c
> > +++ b/drivers/fpga/socfpga.c
> > @@ -577,7 +577,7 @@ static int socfpga_fpga_probe(struct platform_device *pdev)
> >  
> >  	ret = devm_request_irq(dev, priv->irq, socfpga_fpga_isr, 0,
> >  			       dev_name(dev), priv);
> > -	if (IS_ERR_VALUE(ret))
> > +	if (ret)
> >  		return ret;
> >  
> >  	return fpga_mgr_register(dev, "Altera SOCFPGA FPGA Manager",
> > -- 
> > 2.4.3
> > 
> > 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]