* [PATCH 2/2] drivers:staging:gdm72xx Fix line over 80 characters
@ 2015-10-31 14:00 Bogicevic Sasa
2015-10-31 15:57 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Bogicevic Sasa @ 2015-10-31 14:00 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, Bogicevic Sasa
This fixes line over 80 characters message from checkpatch.pl
Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
---
drivers/staging/gdm72xx/gdm_qos.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c
index c03204b..0625a54 100644
--- a/drivers/staging/gdm72xx/gdm_qos.c
+++ b/drivers/staging/gdm72xx/gdm_qos.c
@@ -382,7 +382,8 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size)
spin_lock_irqsave(&qcb->qos_lock, flags);
qcb->csr[index].sfid = sfid;
- qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) & 0xff00);
+ qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) &
+ 0xff00);
qcb->csr[index].classifier_rule_en += buf[pos++];
if (qcb->csr[index].classifier_rule_en == 0)
qcb->qos_null_idx = index;
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] drivers:staging:gdm72xx Fix line over 80 characters
2015-10-31 14:00 [PATCH 2/2] drivers:staging:gdm72xx Fix line over 80 characters Bogicevic Sasa
@ 2015-10-31 15:57 ` Joe Perches
2015-10-31 16:39 ` Bogicevic Sasa
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2015-10-31 15:57 UTC (permalink / raw)
To: Bogicevic Sasa; +Cc: gregkh, linux-kernel
On Sat, 2015-10-31 at 15:00 +0100, Bogicevic Sasa wrote:
> This fixes line over 80 characters message from checkpatch.pl
[]
> diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c
[]
> @@ -382,7 +382,8 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size)
>
> spin_lock_irqsave(&qcb->qos_lock, flags);
> qcb->csr[index].sfid = sfid;
> - qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) & 0xff00);
> + qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) &
> + 0xff00);
Probably better to remove the unnecessary parentheses instead
qcb->csr[index].classifier_rule_en = (buf[pos++] << 8) & 0xff00;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] drivers:staging:gdm72xx Fix line over 80 characters
2015-10-31 15:57 ` Joe Perches
@ 2015-10-31 16:39 ` Bogicevic Sasa
0 siblings, 0 replies; 3+ messages in thread
From: Bogicevic Sasa @ 2015-10-31 16:39 UTC (permalink / raw)
To: Joe Perches; +Cc: gregkh, linux-kernel
On 10/31, Joe Perches wrote:
>On Sat, 2015-10-31 at 15:00 +0100, Bogicevic Sasa wrote:
>> This fixes line over 80 characters message from checkpatch.pl
>[]
>> diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c
>[]
>> @@ -382,7 +382,8 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size)
>>
>> spin_lock_irqsave(&qcb->qos_lock, flags);
>> qcb->csr[index].sfid = sfid;
>> - qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) & 0xff00);
>> + qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) &
>> + 0xff00);
>
>Probably better to remove the unnecessary parentheses instead
>
> qcb->csr[index].classifier_rule_en = (buf[pos++] << 8) & 0xff00;
>
>
>
You're right, I just sent a new patch.
Thanks,
Sasa
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-31 16:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-31 14:00 [PATCH 2/2] drivers:staging:gdm72xx Fix line over 80 characters Bogicevic Sasa
2015-10-31 15:57 ` Joe Perches
2015-10-31 16:39 ` Bogicevic Sasa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox