From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Ranjith <ranjithece24@gmail.com>,
devel@driverdev.osuosl.org, Ian Abbott <abbotti@mev.co.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] comedi: drivers: Fix - BIT macro used coding style issue
Date: Sun, 1 Nov 2015 10:11:35 -0800 [thread overview]
Message-ID: <20151101181135.GB14252@kroah.com> (raw)
In-Reply-To: <20151101181059.GA14252@kroah.com>
On Sun, Nov 01, 2015 at 10:10:59AM -0800, Greg Kroah-Hartman wrote:
> On Sun, Nov 01, 2015 at 12:20:59PM +0200, Andy Shevchenko wrote:
> > On Sun, Nov 1, 2015 at 11:59 AM, Ranjith <ranjithece24@gmail.com> wrote:
> > > BIT macro is used for defining bit location instead of shifting
> > > operator - coding style issue
> >
> > > #define APCI1032_CTRL_INT_OR (0 << 1)
> >
> > > +#define APCI1032_CTRL_INT_AND BIT(1)
> >
> > And now you have two styles at the same time. I wouldn't change the
> > current definitions.
>
> Yes you should, just use BIT(0) for this one.
Oh wait, nevermind, just use the "real" value instead, but using the
BIT() macro is the correct thing, don't tell people not to use it.
prev parent reply other threads:[~2015-11-01 18:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-01 9:59 [PATCH] comedi: drivers: Fix - BIT macro used coding style issue Ranjith
2015-11-01 10:20 ` Andy Shevchenko
2015-11-01 18:10 ` Greg Kroah-Hartman
2015-11-01 18:11 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151101181135.GB14252@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=andy.shevchenko@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ranjithece24@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox