From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-pwm@vger.kernel.org, Qipeng Zha <qipeng.zha@intel.com>,
Huiquan Zhong <huiquan.zhong@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] pwm: lpss: Add support for multiple PWMs
Date: Fri, 6 Nov 2015 15:36:02 +0200 [thread overview]
Message-ID: <20151106133602.GY1509@lahna.fi.intel.com> (raw)
In-Reply-To: <20151106132953.GA31797@ulmo>
On Fri, Nov 06, 2015 at 02:29:53PM +0100, Thierry Reding wrote:
> On Tue, Oct 20, 2015 at 04:53:05PM +0300, Mika Westerberg wrote:
> > New Intel SoCs such as Broxton will have four PWMs per PCI (or ACPI)
> > device. Each PWM has 1k of register space allocated from the parent device.
> > Add support for this.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > ---
> > drivers/pwm/pwm-lpss.c | 48 +++++++++++++++++++++++++++---------------------
> > drivers/pwm/pwm-lpss.h | 1 +
> > 2 files changed, 28 insertions(+), 21 deletions(-)
>
> Applied all three patches, with a minor cleanup, see below.
>
> > diff --git a/drivers/pwm/pwm-lpss.h b/drivers/pwm/pwm-lpss.h
> > index aa041bb1b67d..ef2419f47c57 100644
> > --- a/drivers/pwm/pwm-lpss.h
> > +++ b/drivers/pwm/pwm-lpss.h
> > @@ -20,6 +20,7 @@ struct pwm_lpss_chip;
> >
> > struct pwm_lpss_boardinfo {
> > unsigned long clk_rate;
> > + size_t npwm;
> > };
>
> I changed the type of npwm to unsigned int to match the definition of
> the pwm_chip.npwm field.
Thanks!
prev parent reply other threads:[~2015-11-06 13:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 13:53 [PATCH 1/3] pwm: lpss: Add support for multiple PWMs Mika Westerberg
2015-10-20 13:53 ` [PATCH 2/3] pwm: lpss: Support all four PWMs on Intel Broxton Mika Westerberg
2015-10-20 13:53 ` [PATCH 3/3] pwm: lpss: Add more Intel Broxton IDs Mika Westerberg
2015-11-06 9:15 ` [PATCH 1/3] pwm: lpss: Add support for multiple PWMs Mika Westerberg
2015-11-06 13:29 ` Thierry Reding
2015-11-06 13:36 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151106133602.GY1509@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=huiquan.zhong@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=qipeng.zha@intel.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox