* [PATCH] ch7006: correctly handling failed allocation
@ 2016-01-28 23:54 Insu Yun
2016-02-09 9:22 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Insu Yun @ 2016-01-28 23:54 UTC (permalink / raw)
To: airlied, daniel.vetter, ville.syrjala, alexander.deucher, treding,
boris.brezillon, dri-devel, linux-kernel
Cc: taesoo, yeongjin.jang, insu, changwoo, Insu Yun
Since drm_property_create_range can be failed in memory pressure,
it needs to be checked and return -ENOMEM.
Signed-off-by: Insu Yun <wuninsu@gmail.com>
---
drivers/gpu/drm/i2c/ch7006_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c
index 90db5f4..0594c45 100644
--- a/drivers/gpu/drm/i2c/ch7006_drv.c
+++ b/drivers/gpu/drm/i2c/ch7006_drv.c
@@ -253,6 +253,8 @@ static int ch7006_encoder_create_resources(struct drm_encoder *encoder,
drm_mode_create_tv_properties(dev, NUM_TV_NORMS, ch7006_tv_norm_names);
priv->scale_property = drm_property_create_range(dev, 0, "scale", 0, 2);
+ if (!priv->scale_property)
+ return -ENOMEM;
drm_object_attach_property(&connector->base, conf->tv_select_subconnector_property,
priv->select_subconnector);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ch7006: correctly handling failed allocation
2016-01-28 23:54 [PATCH] ch7006: correctly handling failed allocation Insu Yun
@ 2016-02-09 9:22 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2016-02-09 9:22 UTC (permalink / raw)
To: Insu Yun
Cc: airlied, daniel.vetter, ville.syrjala, alexander.deucher, treding,
boris.brezillon, dri-devel, linux-kernel, taesoo, yeongjin.jang,
insu, changwoo
On Thu, Jan 28, 2016 at 06:54:36PM -0500, Insu Yun wrote:
> Since drm_property_create_range can be failed in memory pressure,
> it needs to be checked and return -ENOMEM.
>
> Signed-off-by: Insu Yun <wuninsu@gmail.com>
Applied to drm-misc, thanks.
-Daniel
> ---
> drivers/gpu/drm/i2c/ch7006_drv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c
> index 90db5f4..0594c45 100644
> --- a/drivers/gpu/drm/i2c/ch7006_drv.c
> +++ b/drivers/gpu/drm/i2c/ch7006_drv.c
> @@ -253,6 +253,8 @@ static int ch7006_encoder_create_resources(struct drm_encoder *encoder,
> drm_mode_create_tv_properties(dev, NUM_TV_NORMS, ch7006_tv_norm_names);
>
> priv->scale_property = drm_property_create_range(dev, 0, "scale", 0, 2);
> + if (!priv->scale_property)
> + return -ENOMEM;
>
> drm_object_attach_property(&connector->base, conf->tv_select_subconnector_property,
> priv->select_subconnector);
> --
> 1.9.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-09 9:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-28 23:54 [PATCH] ch7006: correctly handling failed allocation Insu Yun
2016-02-09 9:22 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox