* [PATCH] Staging: comedi: Fix 'unsigned' warning style
@ 2016-03-27 17:52 Aniket Sharma
2016-03-29 9:36 ` Ian Abbott
0 siblings, 1 reply; 2+ messages in thread
From: Aniket Sharma @ 2016-03-27 17:52 UTC (permalink / raw)
To: abbotti; +Cc: devel, linux-kernel
This patch fixes the checkpatch.pl warning:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
+ unsigned runflags;
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
+struct comedi_device *comedi_dev_get_from_minor(unsigned minor);
Signed-off-by: Aniket Sharma <badbuddha91@gmail.com>
---
drivers/staging/comedi/comedidev.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index 1158072..dcb6376 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -173,7 +173,7 @@ struct comedi_subdevice {
void *lock;
void *busy;
- unsigned runflags;
+ unsigned int runflags;
spinlock_t spin_lock; /* generic spin-lock for COMEDI and drivers */
unsigned int io_bits;
@@ -566,7 +566,7 @@ struct comedi_device {
void comedi_event(struct comedi_device *dev, struct comedi_subdevice *s);
-struct comedi_device *comedi_dev_get_from_minor(unsigned minor);
+struct comedi_device *comedi_dev_get_from_minor(unsigned int minor);
int comedi_dev_put(struct comedi_device *dev);
bool comedi_is_subdevice_running(struct comedi_subdevice *s);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Staging: comedi: Fix 'unsigned' warning style
2016-03-27 17:52 [PATCH] Staging: comedi: Fix 'unsigned' warning style Aniket Sharma
@ 2016-03-29 9:36 ` Ian Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Ian Abbott @ 2016-03-29 9:36 UTC (permalink / raw)
To: Aniket Sharma; +Cc: devel, linux-kernel
On 27/03/16 18:52, Aniket Sharma wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> + unsigned runflags;
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> +struct comedi_device *comedi_dev_get_from_minor(unsigned minor);
>
> Signed-off-by: Aniket Sharma <badbuddha91@gmail.com>
> ---
> drivers/staging/comedi/comedidev.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index 1158072..dcb6376 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -173,7 +173,7 @@ struct comedi_subdevice {
>
> void *lock;
> void *busy;
> - unsigned runflags;
> + unsigned int runflags;
> spinlock_t spin_lock; /* generic spin-lock for COMEDI and drivers */
>
> unsigned int io_bits;
> @@ -566,7 +566,7 @@ struct comedi_device {
>
> void comedi_event(struct comedi_device *dev, struct comedi_subdevice *s);
>
> -struct comedi_device *comedi_dev_get_from_minor(unsigned minor);
> +struct comedi_device *comedi_dev_get_from_minor(unsigned int minor);
> int comedi_dev_put(struct comedi_device *dev);
>
> bool comedi_is_subdevice_running(struct comedi_subdevice *s);
>
Thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-29 9:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-27 17:52 [PATCH] Staging: comedi: Fix 'unsigned' warning style Aniket Sharma
2016-03-29 9:36 ` Ian Abbott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox