* [PATCH] memcg: fix stale mem_cgroup_force_empty() comment
@ 2016-05-06 21:23 Greg Thelen
2016-05-06 21:45 ` Johannes Weiner
2016-05-10 7:28 ` Michal Hocko
0 siblings, 2 replies; 3+ messages in thread
From: Greg Thelen @ 2016-05-06 21:23 UTC (permalink / raw)
To: Andrew Morton, Johannes Weiner, Michal Hocko, Vladimir Davydov
Cc: cgroups, linux-mm, linux-kernel, Greg Thelen
commit f61c42a7d911 ("memcg: remove tasks/children test from
mem_cgroup_force_empty()") removed memory reparenting from the function.
Fix the function's comment.
Signed-off-by: Greg Thelen <gthelen@google.com>
---
mm/memcontrol.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index fe787f5c41bd..19fd76168a05 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2636,8 +2636,7 @@ static inline bool memcg_has_children(struct mem_cgroup *memcg)
}
/*
- * Reclaims as many pages from the given memcg as possible and moves
- * the rest to the parent.
+ * Reclaims as many pages from the given memcg as possible.
*
* Caller is responsible for holding css reference for memcg.
*/
--
2.8.0.rc3.226.g39d4020
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] memcg: fix stale mem_cgroup_force_empty() comment
2016-05-06 21:23 [PATCH] memcg: fix stale mem_cgroup_force_empty() comment Greg Thelen
@ 2016-05-06 21:45 ` Johannes Weiner
2016-05-10 7:28 ` Michal Hocko
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Weiner @ 2016-05-06 21:45 UTC (permalink / raw)
To: Greg Thelen
Cc: Andrew Morton, Michal Hocko, Vladimir Davydov, cgroups, linux-mm,
linux-kernel
On Fri, May 06, 2016 at 02:23:30PM -0700, Greg Thelen wrote:
> commit f61c42a7d911 ("memcg: remove tasks/children test from
> mem_cgroup_force_empty()") removed memory reparenting from the function.
>
> Fix the function's comment.
>
> Signed-off-by: Greg Thelen <gthelen@google.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] memcg: fix stale mem_cgroup_force_empty() comment
2016-05-06 21:23 [PATCH] memcg: fix stale mem_cgroup_force_empty() comment Greg Thelen
2016-05-06 21:45 ` Johannes Weiner
@ 2016-05-10 7:28 ` Michal Hocko
1 sibling, 0 replies; 3+ messages in thread
From: Michal Hocko @ 2016-05-10 7:28 UTC (permalink / raw)
To: Greg Thelen
Cc: Andrew Morton, Johannes Weiner, Vladimir Davydov, cgroups,
linux-mm, linux-kernel
On Fri 06-05-16 14:23:30, Greg Thelen wrote:
> commit f61c42a7d911 ("memcg: remove tasks/children test from
> mem_cgroup_force_empty()") removed memory reparenting from the function.
>
> Fix the function's comment.
>
> Signed-off-by: Greg Thelen <gthelen@google.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> mm/memcontrol.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index fe787f5c41bd..19fd76168a05 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -2636,8 +2636,7 @@ static inline bool memcg_has_children(struct mem_cgroup *memcg)
> }
>
> /*
> - * Reclaims as many pages from the given memcg as possible and moves
> - * the rest to the parent.
> + * Reclaims as many pages from the given memcg as possible.
> *
> * Caller is responsible for holding css reference for memcg.
> */
> --
> 2.8.0.rc3.226.g39d4020
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-10 7:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-06 21:23 [PATCH] memcg: fix stale mem_cgroup_force_empty() comment Greg Thelen
2016-05-06 21:45 ` Johannes Weiner
2016-05-10 7:28 ` Michal Hocko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox