* [PATCH -next] mfd: hi655x: Fix return value check in hi655x_pmic_probe()
@ 2016-06-18 17:26 weiyj_lk
2016-06-28 15:25 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: weiyj_lk @ 2016-06-18 17:26 UTC (permalink / raw)
To: Lee Jones; +Cc: Wei Yongjun, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR(). Also remove unneeded error handling of
platform_get_resource().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/mfd/hi655x-pmic.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
index 05ddc78..58bf149 100644
--- a/drivers/mfd/hi655x-pmic.c
+++ b/drivers/mfd/hi655x-pmic.c
@@ -80,12 +80,9 @@ static int hi655x_pmic_probe(struct platform_device *pdev)
pmic->dev = dev;
pmic->res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!pmic->res)
- return -ENOENT;
-
base = devm_ioremap_resource(dev, pmic->res);
- if (!base)
- return -ENOMEM;
+ if (IS_ERR(base))
+ return PTR_ERR(base);
pmic->regmap = devm_regmap_init_mmio_clk(dev, NULL, base,
&hi655x_regmap_config);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] mfd: hi655x: Fix return value check in hi655x_pmic_probe()
2016-06-18 17:26 [PATCH -next] mfd: hi655x: Fix return value check in hi655x_pmic_probe() weiyj_lk
@ 2016-06-28 15:25 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2016-06-28 15:25 UTC (permalink / raw)
To: weiyj_lk; +Cc: Wei Yongjun, linux-kernel
On Sat, 18 Jun 2016, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR(). Also remove unneeded error handling of
> platform_get_resource().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/mfd/hi655x-pmic.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
> index 05ddc78..58bf149 100644
> --- a/drivers/mfd/hi655x-pmic.c
> +++ b/drivers/mfd/hi655x-pmic.c
> @@ -80,12 +80,9 @@ static int hi655x_pmic_probe(struct platform_device *pdev)
> pmic->dev = dev;
>
> pmic->res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!pmic->res)
> - return -ENOENT;
> -
> base = devm_ioremap_resource(dev, pmic->res);
> - if (!base)
> - return -ENOMEM;
> + if (IS_ERR(base))
> + return PTR_ERR(base);
>
> pmic->regmap = devm_regmap_init_mmio_clk(dev, NULL, base,
> &hi655x_regmap_config);
>
>
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-28 15:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-18 17:26 [PATCH -next] mfd: hi655x: Fix return value check in hi655x_pmic_probe() weiyj_lk
2016-06-28 15:25 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox