The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Felipe F. Tonello" <eu@felipetonello.com>
To: linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
	Michal Nazarewicz <mina86@mina86.com>
Subject: [PATCH v3 0/9] Gadget endpoint request allocation and MIDI
Date: Fri,  5 Aug 2016 19:34:52 +0100	[thread overview]
Message-ID: <20160805183501.11993-1-eu@felipetonello.com> (raw)

As discussed with Baolin Wang, Michal Nazarewicz and Felipe Balbi. I propose
the forced buffer alignment of OUT endpoints USB requests. This is implemented
by patches #1 and #2.

That not just simplifies the driver code, but it also prevents nasty bugs when
buflen is not aligned or even less than wMaxPacketSize.

Patch #9  removes direct calls to usb_ep_alloc_request() and use alloc_ep_req()
instead. If accepted, then we should apply to all other gadgets that uses
usb_ep_alloc_request() when possible and encorage drivers to use it instead.

Changes from v2:
 * Simplified logic in patch 1
 * Added documentation to alloc_ep_req and free_ep_req
 * Improved commit message on patch 7

Changes from v1:
 * Added patches 1, 2, 7, 8 ,9.
 * Patch 3 removes max_t() for buffer alignment with wMaxPacketSize

Felipe F. Tonello (9):
  usb: gadget: fix usb_ep_align_maybe endianness and new usb_ep_align
  usb: gadget: align buffer size when allocating for OUT endpoint
  usb: gadget: f_midi: remove alignment code for OUT endpoint
  usb: gadget: f_midi: defaults buflen sizes to 512
  usb: gadget: f_midi: refactor state machine
  usb: gadget: f_midi: drop substreams when disabling endpoint
  usb: gadget: remove useless parameter in alloc_ep_req()
  usb: gadget: f_hid: use free_ep_req()
  usb: gadget: f_hid: use alloc_ep_req()

 drivers/usb/gadget/function/f_hid.c        |  26 +---
 drivers/usb/gadget/function/f_loopback.c   |   9 +-
 drivers/usb/gadget/function/f_midi.c       | 240 +++++++++++++++++------------
 drivers/usb/gadget/function/f_sourcesink.c |  11 +-
 drivers/usb/gadget/legacy/gmidi.c          |   2 +-
 drivers/usb/gadget/u_f.c                   |   6 +-
 drivers/usb/gadget/u_f.h                   |  17 +-
 include/linux/usb/gadget.h                 |  17 +-
 8 files changed, 188 insertions(+), 140 deletions(-)

-- 
2.9.0

             reply	other threads:[~2016-08-05 18:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-05 18:34 Felipe F. Tonello [this message]
2016-08-05 18:34 ` [PATCH v3 1/9] usb: gadget: fix usb_ep_align_maybe endianness and new usb_ep_align Felipe F. Tonello
2016-08-06  2:03   ` Michal Nazarewicz
2016-08-05 18:34 ` [PATCH v3 2/9] usb: gadget: align buffer size when allocating for OUT endpoint Felipe F. Tonello
2016-08-05 19:15   ` kbuild test robot
2016-08-08 17:09     ` Felipe Ferreri Tonello
2016-08-05 18:34 ` [PATCH v3 3/9] usb: gadget: f_midi: remove alignment code " Felipe F. Tonello
2016-08-05 18:34 ` [PATCH v3 4/9] usb: gadget: f_midi: defaults buflen sizes to 512 Felipe F. Tonello
2016-08-06  2:04   ` Michal Nazarewicz
2016-08-05 18:34 ` [PATCH v3 5/9] usb: gadget: f_midi: refactor state machine Felipe F. Tonello
2016-08-05 18:34 ` [PATCH v3 6/9] usb: gadget: f_midi: drop substreams when disabling endpoint Felipe F. Tonello
2016-08-05 18:34 ` [PATCH v3 7/9] usb: gadget: remove useless parameter in alloc_ep_req() Felipe F. Tonello
2016-08-05 18:35 ` [PATCH v3 8/9] usb: gadget: f_hid: use free_ep_req() Felipe F. Tonello
2016-08-05 18:35 ` [PATCH v3 9/9] usb: gadget: f_hid: use alloc_ep_req() Felipe F. Tonello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160805183501.11993-1-eu@felipetonello.com \
    --to=eu@felipetonello.com \
    --cc=balbi@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mina86@mina86.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox