From: "Felipe F. Tonello" <eu@felipetonello.com>
To: linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
Michal Nazarewicz <mina86@mina86.com>
Subject: [PATCH v3 9/9] usb: gadget: f_hid: use alloc_ep_req()
Date: Fri, 5 Aug 2016 19:35:01 +0100 [thread overview]
Message-ID: <20160805183501.11993-10-eu@felipetonello.com> (raw)
In-Reply-To: <20160805183501.11993-1-eu@felipetonello.com>
Use gadget's framework allocation function instead of directly calling
usb_ep_alloc_request().
Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
drivers/usb/gadget/function/f_hid.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c
index a010496e4e05..89d2e9a5a04f 100644
--- a/drivers/usb/gadget/function/f_hid.c
+++ b/drivers/usb/gadget/function/f_hid.c
@@ -611,14 +611,10 @@ static int hidg_bind(struct usb_configuration *c, struct usb_function *f)
/* preallocate request and buffer */
status = -ENOMEM;
- hidg->req = usb_ep_alloc_request(hidg->in_ep, GFP_KERNEL);
+ hidg->req = alloc_ep_req(hidg->in_ep, hidg->report_length);
if (!hidg->req)
goto fail;
- hidg->req->buf = kmalloc(hidg->report_length, GFP_KERNEL);
- if (!hidg->req->buf)
- goto fail;
-
/* set descriptor dynamic values */
hidg_interface_desc.bInterfaceSubClass = hidg->bInterfaceSubClass;
hidg_interface_desc.bInterfaceProtocol = hidg->bInterfaceProtocol;
--
2.9.0
prev parent reply other threads:[~2016-08-05 18:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 18:34 [PATCH v3 0/9] Gadget endpoint request allocation and MIDI Felipe F. Tonello
2016-08-05 18:34 ` [PATCH v3 1/9] usb: gadget: fix usb_ep_align_maybe endianness and new usb_ep_align Felipe F. Tonello
2016-08-06 2:03 ` Michal Nazarewicz
2016-08-05 18:34 ` [PATCH v3 2/9] usb: gadget: align buffer size when allocating for OUT endpoint Felipe F. Tonello
2016-08-05 19:15 ` kbuild test robot
2016-08-08 17:09 ` Felipe Ferreri Tonello
2016-08-05 18:34 ` [PATCH v3 3/9] usb: gadget: f_midi: remove alignment code " Felipe F. Tonello
2016-08-05 18:34 ` [PATCH v3 4/9] usb: gadget: f_midi: defaults buflen sizes to 512 Felipe F. Tonello
2016-08-06 2:04 ` Michal Nazarewicz
2016-08-05 18:34 ` [PATCH v3 5/9] usb: gadget: f_midi: refactor state machine Felipe F. Tonello
2016-08-05 18:34 ` [PATCH v3 6/9] usb: gadget: f_midi: drop substreams when disabling endpoint Felipe F. Tonello
2016-08-05 18:34 ` [PATCH v3 7/9] usb: gadget: remove useless parameter in alloc_ep_req() Felipe F. Tonello
2016-08-05 18:35 ` [PATCH v3 8/9] usb: gadget: f_hid: use free_ep_req() Felipe F. Tonello
2016-08-05 18:35 ` Felipe F. Tonello [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160805183501.11993-10-eu@felipetonello.com \
--to=eu@felipetonello.com \
--cc=balbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mina86@mina86.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox