* [PATCH] drm/hisilicon: add back missing } on ade_dc_ops
@ 2016-08-17 11:09 Colin King
2016-08-17 11:21 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-08-17 11:09 UTC (permalink / raw)
To: Xinliang Liu, Xinwei Kong, Chen Feng, David Airlie, Daniel Vetter,
Eric Engestrom, Maarten Lankhorst, Wei Yongjun, dri-devel
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Fix build error by adding back the closing } on ade_dc_ops which
got accidentally removed from an earlier commit.
Fixes: d25bcfb8c2e18b9b36 ("Don't set drm_device->platformdev")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
index 91188f3..c9f8166 100644
--- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
+++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
@@ -1062,4 +1062,4 @@ static void ade_drm_cleanup(struct platform_device *pdev)
const struct kirin_dc_ops ade_dc_ops = {
.init = ade_drm_init,
.cleanup = ade_drm_cleanup
-;
+};
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/hisilicon: add back missing } on ade_dc_ops
2016-08-17 11:09 [PATCH] drm/hisilicon: add back missing } on ade_dc_ops Colin King
@ 2016-08-17 11:21 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2016-08-17 11:21 UTC (permalink / raw)
To: Colin King
Cc: Xinliang Liu, Xinwei Kong, Chen Feng, David Airlie, Daniel Vetter,
Eric Engestrom, Maarten Lankhorst, Wei Yongjun, dri-devel,
linux-kernel
On Wed, Aug 17, 2016 at 12:09:24PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Fix build error by adding back the closing } on ade_dc_ops which
> got accidentally removed from an earlier commit.
>
> Fixes: d25bcfb8c2e18b9b36 ("Don't set drm_device->platformdev")
Yeah that patch was horribly screwed up, but at least in my testing
there's more broken with it. Does this really fix it?
-Daniel
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> index 91188f3..c9f8166 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> @@ -1062,4 +1062,4 @@ static void ade_drm_cleanup(struct platform_device *pdev)
> const struct kirin_dc_ops ade_dc_ops = {
> .init = ade_drm_init,
> .cleanup = ade_drm_cleanup
> -;
> +};
> --
> 2.9.3
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-17 11:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-17 11:09 [PATCH] drm/hisilicon: add back missing } on ade_dc_ops Colin King
2016-08-17 11:21 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox