From: Lee Jones <lee.jones@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Tony Lindgren <tony@atomide.com>,
Marcin Niestroj <m.niestroj@grinn-global.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: tps65217: fix nonstandard declaration
Date: Wed, 14 Sep 2016 09:37:48 +0100 [thread overview]
Message-ID: <20160914083748.GB638@dell> (raw)
In-Reply-To: <20160914081402.802116-1-arnd@arndb.de>
On Wed, 14 Sep 2016, Arnd Bergmann wrote:
> The tps65217 gained a new warning when building with W=1:
>
> drivers/mfd/tps65217.c:85:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration]
>
> This fixes it by putting the 'inline' modifier before 'const'.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 262d5cc6ceb2 ("mfd: tps65217: Add support for IRQs")
> ---
> drivers/mfd/tps65217.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
FYI: I plan to fix all W=1 and look at W=2 warnings today anyway.
> diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c
> index 57c87412106f..9a4d8684dd32 100644
> --- a/drivers/mfd/tps65217.c
> +++ b/drivers/mfd/tps65217.c
> @@ -82,7 +82,7 @@ static void tps65217_irq_sync_unlock(struct irq_data *data)
> mutex_unlock(&tps->irq_lock);
> }
>
> -static const inline struct tps65217_irq *
> +static inline const struct tps65217_irq *
> irq_to_tps65217_irq(struct tps65217 *tps, struct irq_data *data)
> {
> return &tps65217_irqs[data->hwirq];
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2016-09-14 8:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 8:13 [PATCH] mfd: tps65217: fix nonstandard declaration Arnd Bergmann
2016-09-14 8:37 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914083748.GB638@dell \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m.niestroj@grinn-global.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox